2021-03-23 01:36:04

by Jiele Zhao

Subject: [PATCH] integrity/ima: Add declarations to init_once void arguments.

init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <[email protected]>
---
security/integrity/iint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 1d20003243c3..5f3f2de997e1 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c
@@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)

static void init_once(void *foo)
{
- struct integrity_iint_cache *iint = foo;
+ struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;

memset(iint, 0, sizeof(*iint));
iint->ima_file_status = INTEGRITY_UNKNOWN;
--
2.25.1

2021-03-29 10:21:59

by Jiele Zhao

Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <[email protected]>
> ---
> security/integrity/iint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct integrity_iint_cache *iint = foo;
> + struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
>
> memset(iint, 0, sizeof(*iint));
> iint->ima_file_status = INTEGRITY_UNKNOWN;

2021-04-06 12:49:33

by Jiele Zhao

Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <[email protected]>
> ---
> security/integrity/iint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct integrity_iint_cache *iint = foo;
> + struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
>
> memset(iint, 0, sizeof(*iint));
> iint->ima_file_status = INTEGRITY_UNKNOWN;

2021-04-06 13:00:34

by James Morris

Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

On Tue, 6 Apr 2021, Jiele Zhao wrote:

> Ping.

Mimi Zohar is the maintainer for this code.

>
> On 2021/3/23 9:33, Jiele Zhao wrote:
> > init_once is a callback to kmem_cache_create. The parameter
> > type of this function is void *, so it's better to give a
> > explicit cast here.
> >
> > Signed-off-by: Jiele Zhao <[email protected]>
> > ---
> > security/integrity/iint.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> > index 1d20003243c3..5f3f2de997e1 100644
> > --- a/security/integrity/iint.c
> > +++ b/security/integrity/iint.c
> > @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
> >
> > static void init_once(void *foo)
> > {
> > - struct integrity_iint_cache *iint = foo;
> > + struct integrity_iint_cache *iint = (struct integrity_iint_cache
> > *)foo;
> >
> > memset(iint, 0, sizeof(*iint));
> > iint->ima_file_status = INTEGRITY_UNKNOWN;
>

--
James Morris
<[email protected]>

2021-04-06 16:02:34

by Jiele Zhao

Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

Hi Mimi,

Please see if this is a useful suggestion.

On 2021/4/6 10:38, James Morris wrote:
> On Tue, 6 Apr 2021, Jiele Zhao wrote:
>
>> Ping.
> Mimi Zohar is the maintainer for this code.
>
>> On 2021/3/23 9:33, Jiele Zhao wrote:
>>> init_once is a callback to kmem_cache_create. The parameter
>>> type of this function is void *, so it's better to give a
>>> explicit cast here.
>>>
>>> Signed-off-by: Jiele Zhao <[email protected]>
>>> ---
>>> security/integrity/iint.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
>>> index 1d20003243c3..5f3f2de997e1 100644
>>> --- a/security/integrity/iint.c
>>> +++ b/security/integrity/iint.c
>>> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>>>
>>> static void init_once(void *foo)
>>> {
>>> - struct integrity_iint_cache *iint = foo;
>>> + struct integrity_iint_cache *iint = (struct integrity_iint_cache
>>> *)foo;
>>>
>>> memset(iint, 0, sizeof(*iint));
>>> iint->ima_file_status = INTEGRITY_UNKNOWN;

2021-04-07 02:52:07

by Mimi Zohar

Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.

Hi Jiele,

On Tue, 2021-03-23 at 01:33 +0000, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <[email protected]>

Please remove the "ima" in the Subject line and re-post Cc'ing the
linux-integrity mailing list.

> ---
> security/integrity/iint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct integrity_iint_cache *iint = foo;
> + struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;

Like the other init_once() examples, please add a blank before foo.

thanks,

Mimi
>
> memset(iint, 0, sizeof(*iint));
> iint->ima_file_status = INTEGRITY_UNKNOWN;