Hi Sergey!
On 2/11/22 21:28, Sergey Shtylyov wrote:
> On 2/11/22 11:15 PM, Sergey Shtylyov wrote:
>
>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
>> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify
>> that code to start the IRQ #s from 16 instead.
>>
>> [1] https://lore.kernel.org/all/[email protected]/
>>
>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>
>> ---
>> The patch is against Linus Torvalds' 'linux.git' repo.
>>
>> arch/sh/kernel/cpu/sh3/entry.S | 4 ++--
>> include/linux/sh_intc.h | 6 +++---
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> Index: linux/arch/sh/kernel/cpu/sh3/entry.S
>> ===================================================================
>> --- linux.orig/arch/sh/kernel/cpu/sh3/entry.S
>> +++ linux/arch/sh/kernel/cpu/sh3/entry.S
>> @@ -470,9 +470,9 @@ ENTRY(handle_interrupt)
>> mov r4, r0 ! save vector->jmp table offset for later
>>
>> shlr2 r4 ! vector to IRQ# conversion
>> - add #-0x10, r4
>>
>> - cmp/pz r4 ! is it a valid IRQ?
>> + mov #0x10, r5
>> + cmp/ge r5, r4 ! is it a valid IRQ?
>
> Maybe I should've used cmp/hs... my 1st try at SH assembly! :-)
I can test your revised patch next week on my SH7785LCR.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
On 2/11/22 11:30 PM, John Paul Adrian Glaubitz wrote:
[...]
>>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
>>> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify
>>> that code to start the IRQ #s from 16 instead.
>>>
>>> [1] https://lore.kernel.org/all/[email protected]/
>>>
>>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>>
>>> ---
>>> The patch is against Linus Torvalds' 'linux.git' repo.
>>>
>>> arch/sh/kernel/cpu/sh3/entry.S | 4 ++--
>>> include/linux/sh_intc.h | 6 +++---
>>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> Index: linux/arch/sh/kernel/cpu/sh3/entry.S
>>> ===================================================================
>>> --- linux.orig/arch/sh/kernel/cpu/sh3/entry.S
>>> +++ linux/arch/sh/kernel/cpu/sh3/entry.S
>>> @@ -470,9 +470,9 @@ ENTRY(handle_interrupt)
>>> mov r4, r0 ! save vector->jmp table offset for later
>>>
>>> shlr2 r4 ! vector to IRQ# conversion
>>> - add #-0x10, r4
>>>
>>> - cmp/pz r4 ! is it a valid IRQ?
>>> + mov #0x10, r5
>>> + cmp/ge r5, r4 ! is it a valid IRQ?
>>
>> Maybe I should've used cmp/hs... my 1st try at SH assembly! :-)
Yeah, cmp/hs seems m ore correct as we don't subtract any more...
> I can test your revised patch next week on my SH7785LCR.
Please do, although testing on the AP-SH4A* bords would be a bit more
interesting, as they actually use IRQ0 for the SMSC911x chip...
Maybe you have SH7786 base board, by chance?
> Thanks,
> Adrian
MBR, Sergey
On 2/11/22 11:46 PM, Sergey Shtylyov wrote:
[...]
>>>> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
>>>> and the code supporting SH3/4 SoCs maps the IRQ #s starting at 0 -- modify
>>>> that code to start the IRQ #s from 16 instead.
>>>>
>>>> [1] https://lore.kernel.org/all/[email protected]/
>>>>
>>>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>>>
>>>> ---
>>>> The patch is against Linus Torvalds' 'linux.git' repo.
>>>>
>>>> arch/sh/kernel/cpu/sh3/entry.S | 4 ++--
>>>> include/linux/sh_intc.h | 6 +++---
>>>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> Index: linux/arch/sh/kernel/cpu/sh3/entry.S
>>>> ===================================================================
>>>> --- linux.orig/arch/sh/kernel/cpu/sh3/entry.S
>>>> +++ linux/arch/sh/kernel/cpu/sh3/entry.S
>>>> @@ -470,9 +470,9 @@ ENTRY(handle_interrupt)
>>>> mov r4, r0 ! save vector->jmp table offset for later
>>>>
>>>> shlr2 r4 ! vector to IRQ# conversion
>>>> - add #-0x10, r4
>>>>
>>>> - cmp/pz r4 ! is it a valid IRQ?
>>>> + mov #0x10, r5
>>>> + cmp/ge r5, r4 ! is it a valid IRQ?
>>>
>>> Maybe I should've used cmp/hs... my 1st try at SH assembly! :-)
>
> Yeah, cmp/hs seems m ore correct as we don't subtract any more...
>
>> I can test your revised patch next week on my SH7785LCR.
>
> Please do, although testing on the AP-SH4A* bords would be a bit more
> interesting, as they actually use IRQ0 for the SMSC911x chip...
So, were you finally able to test it?
[...]
MBR, Sergey
Hi Sergey!
On 2/25/22 20:28, Sergey Shtylyov wrote:
>>> I can test your revised patch next week on my SH7785LCR.
>>
>> Please do, although testing on the AP-SH4A* bords would be a bit more
>> interesting, as they actually use IRQ0 for the SMSC911x chip...
>
> So, were you finally able to test it?
Not yet, sorry. Machine is currently offline due to a power outage and I cannot
turn it back on remotely, I'm not home until tomorrow. I will be able to test
it tomorrow, however.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Hello!
On 2/26/22 11:07 AM, John Paul Adrian Glaubitz wrote:
[...]
>>>> I can test your revised patch next week on my SH7785LCR.
>>>
>>> Please do, although testing on the AP-SH4A* bords would be a bit more
>>> interesting, as they actually use IRQ0 for the SMSC911x chip...
>>
>> So, were you finally able to test it?
>
> Not yet, sorry. Machine is currently offline due to a power outage and I cannot
> turn it back on remotely, I'm not home until tomorrow. I will be able to test
> it tomorrow, however.
And? :-)
> Adrian
MBR, Sergey
Hi Sergey!
On 3/2/22 10:31, Sergey Shtylyov wrote:
>>>>> I can test your revised patch next week on my SH7785LCR.
>>>>
>>>> Please do, although testing on the AP-SH4A* bords would be a bit more
>>>> interesting, as they actually use IRQ0 for the SMSC911x chip...
>>>
>>> So, were you finally able to test it?
>>
>> Not yet, sorry. Machine is currently offline due to a power outage and I cannot
>> turn it back on remotely, I'm not home until tomorrow. I will be able to test
>> it tomorrow, however.
>
> And? :-)
Sorry, got distracted by other stuff. Will test it right now and let you know
later today.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913