2020-07-15 04:24:03

by Sowjanya Komatineni

Subject: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies

This patch adds IMX274 optional external clock input and voltage
supplies to device tree bindings.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
index 80f2e89..ee427f5 100644
--- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
+++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
@@ -13,6 +13,11 @@ Required Properties:

Optional Properties:
- reset-gpios: Sensor reset GPIO
+- clocks: Reference to the xclk clock.
+- clock-names: Should be "xclk".
+- VANA-supply: Sensor 2.8v analog supply.
+- VDIG-supply: Sensor 1.8v digital core supply.
+- VDDL-supply: Sensor digital IO 1.2v supply.

The imx274 device node should contain one 'port' child node with
an 'endpoint' subnode. For further reading on port node refer to
--
2.7.4

2020-07-16 06:51:27

by Luca Ceresoli

Subject: Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies

Hi Sowjanya,

On 15/07/20 06:24, Sowjanya Komatineni wrote:
> This patch adds IMX274 optional external clock input and voltage
> supplies to device tree bindings.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> index 80f2e89..ee427f5 100644
> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> @@ -13,6 +13,11 @@ Required Properties:
>
> Optional Properties:
> - reset-gpios: Sensor reset GPIO
> +- clocks: Reference to the xclk clock.
> +- clock-names: Should be "xclk".

Not sure where the "xclk" name comes from, the datasheet I have calls
the pin "CKIN". Maybe using the same name as the datasheet is better?

Other than that looks good.

--
Luca

2020-07-16 23:33:23

by Sowjanya Komatineni

Subject: Re: [PATCH v1 2/3] dt-bindings: media: imx274: Add optional xclk and supplies

On 7/15/20 11:50 PM, Luca Ceresoli wrote:
> Hi Sowjanya,
>
> On 15/07/20 06:24, Sowjanya Komatineni wrote:
>> This patch adds IMX274 optional external clock input and voltage
>> supplies to device tree bindings.
>>
>> Signed-off-by: Sowjanya Komatineni <[email protected]>
>> ---
>> Documentation/devicetree/bindings/media/i2c/imx274.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> index 80f2e89..ee427f5 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> @@ -13,6 +13,11 @@ Required Properties:
>>
>> Optional Properties:
>> - reset-gpios: Sensor reset GPIO
>> +- clocks: Reference to the xclk clock.
>> +- clock-names: Should be "xclk".
> Not sure where the "xclk" name comes from, the datasheet I have calls
> the pin "CKIN". Maybe using the same name as the datasheet is better?
>
> Other than that looks good.

Thanks Luca. Using xclk as its external clock to IMX274.

Datasheet uses it as INCK. Will update in v2 to use "INCK" as referred
in its datasheet.