2019-05-02 08:17:11

by Michal Rostecki

Subject: [PATCH bpf-next v2] bpf, libbpf: Add .so files to gitignore

This change adds libbpf shared libraries to .gitignore which were
previously not included there.

Acked-by: Yonghong Song <[email protected]>
Signed-off-by: Michal Rostecki <[email protected]>
---
tools/lib/bpf/.gitignore | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/lib/bpf/.gitignore b/tools/lib/bpf/.gitignore
index 7d9e182a1f51..0b181b23f97d 100644
--- a/tools/lib/bpf/.gitignore
+++ b/tools/lib/bpf/.gitignore
@@ -1,4 +1,5 @@
libbpf_version.h
libbpf.pc
+libbpf.so.0*
FEATURE-DUMP.libbpf
test_libbpf
--
2.21.0

2019-05-05 07:06:32

by Alexei Starovoitov

Subject: Re: [PATCH bpf-next v2] bpf, libbpf: Add .so files to gitignore

On Thu, May 2, 2019 at 1:15 AM Michal Rostecki <[email protected]> wrote:
>
> This change adds libbpf shared libraries to .gitignore which were
> previously not included there.
>
> Acked-by: Yonghong Song <[email protected]>
> Signed-off-by: Michal Rostecki <[email protected]>
> ---
> tools/lib/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/lib/bpf/.gitignore b/tools/lib/bpf/.gitignore
> index 7d9e182a1f51..0b181b23f97d 100644
> --- a/tools/lib/bpf/.gitignore
> +++ b/tools/lib/bpf/.gitignore
> @@ -1,4 +1,5 @@
> libbpf_version.h
> libbpf.pc
> +libbpf.so.0*

Some folks build libbpf as part of selftests.
Please update .gitignore in tools/lib/bpf and
in tools/testing/selftests/bpf

Also instead of "bpf, libbpf:" subj prefix just mention "libbpf:"

2019-05-06 08:30:39

by Michal Rostecki

Subject: Re: [PATCH bpf-next v2] bpf, libbpf: Add .so files to gitignore

Am 2019-05-05 09:03, schrieb Alexei Starovoitov:
> Some folks build libbpf as part of selftests.
> Please update .gitignore in tools/lib/bpf and
> in tools/testing/selftests/bpf
>
> Also instead of "bpf, libbpf:" subj prefix just mention "libbpf:"

Thanks for your review!

I noticed that in the meantime the .gitignore file in tools/lib/bpf was
fixed
by the other commit (39391377f8ec). Now I need to fix only .gitignore in
tools/testing/selftests/bpf (where I need to add even more files,
because
some test program binaries are not included too). I will send a patch
for that
later today.