2019-06-18 15:15:40

by Colin King

Subject: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

From: Colin Ian King <[email protected]>

Function mlx5_devlink_alloc is missing a void argument, add it
to clean up the non-ANSI function declaration.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
index ed4202e883f0..1533c657220b 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
@@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops = {
.flash_update = mlx5_devlink_flash_update,
};

-struct devlink *mlx5_devlink_alloc()
+struct devlink *mlx5_devlink_alloc(void)
{
return devlink_alloc(&mlx5_devlink_ops, sizeof(struct mlx5_core_dev));
}
--
2.20.1

2019-06-18 19:03:22

by Saeed Mahameed

Subject: Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

On Tue, 2019-06-18 at 16:15 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index ed4202e883f0..1533c657220b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -37,7 +37,7 @@ static const struct devlink_ops mlx5_devlink_ops =
> {
> .flash_update = mlx5_devlink_flash_update,
> };
>
> -struct devlink *mlx5_devlink_alloc()
> +struct devlink *mlx5_devlink_alloc(void)
> {
> return devlink_alloc(&mlx5_devlink_ops, sizeof(struct
> mlx5_core_dev));
> }

Acked-by: Saeed Mahameed <[email protected]>

Dave, this one can go to net-next.

Thanks,
Saeed.

2019-06-19 02:31:19

by David Miller

Subject: Re: [PATCH][next] net/mlx5: add missing void argument to function mlx5_devlink_alloc

From: Colin King <[email protected]>
Date: Tue, 18 Jun 2019 16:15:10 +0100

> From: Colin Ian King <[email protected]>
>
> Function mlx5_devlink_alloc is missing a void argument, add it
> to clean up the non-ANSI function declaration.
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied.