2023-12-13 12:56:48

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH v10 20/50] KVM: SEV: Select CONFIG_KVM_SW_PROTECTED_VM when CONFIG_KVM_AMD_SEV=y

On 10/16/23 15:27, Michael Roth wrote:
> SEV-SNP relies on the restricted/protected memory support to run guests,
> so make sure to enable that support with the
> CONFIG_KVM_SW_PROTECTED_VM build option.
>
> Signed-off-by: Michael Roth<[email protected]>
> ---

Why select KVM_SW_PROTECTED_VM and not KVM_GENERIC_PRIVATE_MEM?

Paolo


2023-12-30 16:31:39

by Michael Roth

[permalink] [raw]
Subject: Re: [PATCH v10 20/50] KVM: SEV: Select CONFIG_KVM_SW_PROTECTED_VM when CONFIG_KVM_AMD_SEV=y

On Wed, Dec 13, 2023 at 01:54:55PM +0100, Paolo Bonzini wrote:
> On 10/16/23 15:27, Michael Roth wrote:
> > SEV-SNP relies on the restricted/protected memory support to run guests,
> > so make sure to enable that support with the
> > CONFIG_KVM_SW_PROTECTED_VM build option.
> >
> > Signed-off-by: Michael Roth<[email protected]>
> > ---
>
> Why select KVM_SW_PROTECTED_VM and not KVM_GENERIC_PRIVATE_MEM?

I'm not sure, maybe there were previous iterations where it made sense
but KVM_GENERIC_PRIVATE_MEM definitely seems more appropriate now. I've
changed it accordingly.

-Mike

>
> Paolo
>
>