2005-11-03 18:13:12

by Kris Katterjohn

[permalink] [raw]
Subject: Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c;kernel 2.6.14

From: Patrick McHardy
> Mitchell Blank Jr wrote:
> > Well the original author presumably thought that the fast-path of
> > load_pointer() was critical enough to keep inline (since it can be run many
> > times per packet) So they made the deliberate choice of separating it
> > into two functions - one inline, one non-inline.
>
> Exactly. __load_pointer is only called rarely, while load_pointer is
> called whenever data needs to be read from the packet. It shouldn't
> be changed without any justification.


That's a good enough answer for me!


Thanks