2021-06-09 17:29:07

by Sander Vanheule

[permalink] [raw]
Subject: [PATCH v2 0/2] Clause-22/Clause-45 MDIO regmap support fixups

A proposed patch to make C22 access more strict [1], was posted in reply to an
RFC series which also added C45 register access [2]. It appears that as a
result, the original RFC patches got merged instead.

Access functions are corrected to return -ENXIO, instead of silently ignoring
any invalid high bits in the register offset.
Additionally, a warning about a discarded const qualifier is fixed.

[1] Proposed C22 patch:
https://lore.kernel.org/lkml/[email protected]/

[2] RFC series:
https://lore.kernel.org/lkml/[email protected]/

---
Changes since v1:
Link: https://lore.kernel.org/lkml/[email protected]/
- Keep C45 access code, but apply fix for discarded pointer constness
- Return -ENXIO for invalid C45 access too, as done for invalid C22 access

Sander Vanheule (2):
regmap: mdio: Fix regmap_bus pointer constness
regmap: mdio: Reject invalid addresses

drivers/base/regmap/regmap-mdio.c | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)

--
2.31.1


2021-06-14 19:56:44

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Clause-22/Clause-45 MDIO regmap support fixups

On Wed, 9 Jun 2021 15:10:02 +0200, Sander Vanheule wrote:
> A proposed patch to make C22 access more strict [1], was posted in reply to an
> RFC series which also added C45 register access [2]. It appears that as a
> result, the original RFC patches got merged instead.
>
> Access functions are corrected to return -ENXIO, instead of silently ignoring
> any invalid high bits in the register offset.
> Additionally, a warning about a discarded const qualifier is fixed.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/2] regmap: mdio: Fix regmap_bus pointer constness
commit: ce62df2290bb86b39f826a835d6060bc3b43dae7
[2/2] regmap: mdio: Reject invalid addresses
commit: 0df0240946b1ffbe852fa302c04c0d322229c9ce

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark