2023-07-28 18:21:14

by Shuah Khan

[permalink] [raw]
Subject: [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES

The test compile fails with following errors. Fix the Makefile
CFLAGS to include KHDR_INCLUDES to pull in uapi defines.

gcc -Wall proc_filter.c -o ../tools/testing/selftests/connector/proc_filter
proc_filter.c: In function ‘send_message’:
proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
22 | sizeof(struct proc_input))
| ^~~~~~
proc_filter.c:42:19: note: in expansion of macro ‘NL_MESSAGE_SIZE’
42 | char buff[NL_MESSAGE_SIZE];
| ^~~~~~~~~~~~~~~
proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
22 | sizeof(struct proc_input))
| ^~~~~~
proc_filter.c:48:34: note: in expansion of macro ‘NL_MESSAGE_SIZE’
48 | hdr->nlmsg_len = NL_MESSAGE_SIZE;
| ^~~~~~~~~~~~~~~
`

Reported-by: Naresh Kamboju <[email protected]>
Link: https://lore.kernel.org/all/CA+G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com/
Signed-off-by: Shuah Khan <[email protected]>
---
tools/testing/selftests/connector/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/connector/Makefile b/tools/testing/selftests/connector/Makefile
index 21c9f3a973a0..92188b9bac5c 100644
--- a/tools/testing/selftests/connector/Makefile
+++ b/tools/testing/selftests/connector/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wall
+CFLAGS += -Wall $(KHDR_INCLUDES)

TEST_GEN_PROGS = proc_filter

--
2.39.2



2023-07-31 23:10:53

by Anjali Kulkarni

[permalink] [raw]
Subject: Re: [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES



> On Jul 28, 2023, at 10:29 AM, Shuah Khan <[email protected]> wrote:
>
> The test compile fails with following errors. Fix the Makefile
> CFLAGS to include KHDR_INCLUDES to pull in uapi defines.
>
> gcc -Wall proc_filter.c -o ../tools/testing/selftests/connector/proc_filter
> proc_filter.c: In function ‘send_message’:
> proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
> 22 | sizeof(struct proc_input))
> | ^~~~~~
> proc_filter.c:42:19: note: in expansion of macro ‘NL_MESSAGE_SIZE’
> 42 | char buff[NL_MESSAGE_SIZE];
> | ^~~~~~~~~~~~~~~
> proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
> 22 | sizeof(struct proc_input))
> | ^~~~~~
> proc_filter.c:48:34: note: in expansion of macro ‘NL_MESSAGE_SIZE’
> 48 | hdr->nlmsg_len = NL_MESSAGE_SIZE;
> | ^~~~~~~~~~~~~~~
> `
>
> Reported-by: Naresh Kamboju <[email protected]>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CA*[email protected]/__;Kw!!ACWV5N9M2RV99hQ!LJI4riV83FdITmzoXmCfxlHKGSeevxg-wn6_ISa7txpETYWPxbtVkAtxSg6IZGi3k5oh2BKMyrbn9464kchHYnuqPEaU$
> Signed-off-by: Shuah Khan <[email protected]>

Reviewed-by: Anjali Kulkarni <[email protected]>

> ---
> tools/testing/selftests/connector/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/connector/Makefile b/tools/testing/selftests/connector/Makefile
> index 21c9f3a973a0..92188b9bac5c 100644
> --- a/tools/testing/selftests/connector/Makefile
> +++ b/tools/testing/selftests/connector/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -Wall
> +CFLAGS += -Wall $(KHDR_INCLUDES)
>
> TEST_GEN_PROGS = proc_filter
>
> --
> 2.39.2
>