2022-09-14 10:36:22

by Jiapeng Chong

Subject: [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()

The function dac_read_reg() is defined in the arkfb.c file, but not
called elsewhere, so delete this unused function.

drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/video/fbdev/arkfb.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index a317d9fe1d67..5f8fec9e5fd4 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -318,14 +318,6 @@ struct dac_info
void *data;
};

-
-static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
-{
- u8 code[2] = {reg, 0};
- info->dac_read_regs(info->data, code, 1);
- return code[1];
-}
-
static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
{
info->dac_read_regs(info->data, code, count);
--
2.20.1.7.g153144c

2022-09-25 11:23:11

by Helge Deller

Subject: Re: [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()

On 9/14/22 12:23, Jiapeng Chong wrote:
> The function dac_read_reg() is defined in the arkfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

applied.

Thanks,
Helge

> ---
> drivers/video/fbdev/arkfb.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index a317d9fe1d67..5f8fec9e5fd4 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -318,14 +318,6 @@ struct dac_info
> void *data;
> };
>
> -
> -static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
> -{
> - u8 code[2] = {reg, 0};
> - info->dac_read_regs(info->data, code, 1);
> - return code[1];
> -}
> -
> static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
> {
> info->dac_read_regs(info->data, code, count);