2023-09-12 05:03:35

by Reinette Chatre

[permalink] [raw]
Subject: Re: [PATCH v9 6/9] x86/resctrl: Move default group file creation to mount

Hi Babu,

On 9/7/2023 4:51 PM, Babu Moger wrote:
> The default resource group and its files are created during kernel
> init time. Upcoming changes will make some resctrl files optional
> based on a mount parameter. If optional files are to be added to the
> default group based on the mount option, then each new file needs to
> be created separately and call kernfs_activate() again.
>
> Create all files of the default resource group during resctrl
> mount, destroyed during unmount, to avoid scattering resctrl
> file addition across two separate code flows.
>
> Suggested-by: Reinette Chatre <[email protected]>
> Signed-off-by: Babu Moger <[email protected]>

Thank you.

Reviewed-by: Reinette Chatre <[email protected]>

Reinette