This issue was detected by using the Coccinelle software:
tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
The conversion to bool is unneeded, remove it
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
tools/perf/builtin-script.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 02d64a9..e849747 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
break;
}
if (i == imax && strcmp(tok, "flags") == 0) {
- print_flags = change == REMOVE ? false : true;
+ print_flags = change == REMOVE;
continue;
}
if (i == imax) {
@@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
static bool is_top_script(const char *script_path)
{
- return ends_with(script_path, "top") == NULL ? false : true;
+ return ends_with(script_path, "top") == NULL;
}
static int has_required_arg(char *script_path)
--
2.6.2
On Sun, 2020-04-26 at 20:31 +0800, Zou Wei wrote:
> This issue was detected by using the Coccinelle software:
>
> tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
>
> The conversion to bool is unneeded, remove it
[]
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
[]
> @@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
> break;
> }
> if (i == imax && strcmp(tok, "flags") == 0) {
> - print_flags = change == REMOVE ? false : true;
> + print_flags = change == REMOVE;
Read the deleted code above this again.
(you have inverted the logic)
> continue;
> }
> if (i == imax) {
> @@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
>
> static bool is_top_script(const char *script_path)
> {
> - return ends_with(script_path, "top") == NULL ? false : true;
> + return ends_with(script_path, "top") == NULL;
and here.
Em Sun, Apr 26, 2020 at 08:31:05PM +0800, Zou Wei escreveu:
> This issue was detected by using the Coccinelle software:
>
> tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
>
> The conversion to bool is unneeded, remove it
Thanks, applied,
- Arnaldo
On Tue, 2020-04-28 at 14:50 -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Apr 26, 2020 at 08:31:05PM +0800, Zou Wei escreveu:
> > This issue was detected by using the Coccinelle software:
> >
> > tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
> > tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here
> >
> > The conversion to bool is unneeded, remove it
>
> Thanks, applied,
Did you read the patch?
It's broken, unless some other patch was applied.
On April 28, 2020 6:58:46 PM GMT-03:00, Joe Perches <[email protected]> wrote:
>On Tue, 2020-04-28 at 14:50 -0300, Arnaldo Carvalho de Melo wrote:
>> Em Sun, Apr 26, 2020 at 08:31:05PM +0800, Zou Wei escreveu:
>> > This issue was detected by using the Coccinelle software:
>> >
>> > tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool
>not needed here
>> > tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool
>not needed here
>> >
>> > The conversion to bool is unneeded, remove it
>>
>> Thanks, applied,
>
>Did you read the patch?
>It's broken, unless some other patch was applied.
Of course I read it, but yeah, I made a mistake, thanks for pointing out, I'll remove it, thanks.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.