2021-03-23 07:10:22

by Zou Wei

Subject: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword

Fix the following sparse warning:

drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
'format_attr_contextid' was not declared. Should it be static?

Signed-off-by: Zou Wei <[email protected]>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 0f603b4094f2..bdbb77334329 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
return sprintf(page, "config:%d\n", pid_fmt);
}

-struct device_attribute format_attr_contextid =
+static struct device_attribute format_attr_contextid =
__ATTR(contextid, 0444, format_attr_contextid_show, NULL);

static struct attribute *etm_config_formats_attr[] = {
--
2.17.1

2021-03-23 07:23:21

by Leo Yan

Subject: Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword

On Tue, Mar 23, 2021 at 07:54:52AM +0000, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <[email protected]>

Reviewed-by: Leo Yan <[email protected]>

> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 0f603b4094f2..bdbb77334329 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -58,7 +58,7 @@ static ssize_t format_attr_contextid_show(struct device *dev,
> return sprintf(page, "config:%d\n", pid_fmt);
> }
>
> -struct device_attribute format_attr_contextid =
> +static struct device_attribute format_attr_contextid =
> __ATTR(contextid, 0444, format_attr_contextid_show, NULL);
>
> static struct attribute *etm_config_formats_attr[] = {
> --
> 2.17.1
>

2021-03-23 09:51:55

by Suzuki K Poulose

Subject: Re: [PATCH -next] coresight: etm-perf: Mark format_attr_contextid with static keyword

On 23/03/2021 07:54, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol
> 'format_attr_contextid' was not declared. Should it be static?
>

A fix is already queued in coresight/next.

Thanks

Suzuki