When drivers are working properly, they are quiet.
Therefore, the fb_info() should be removed.
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/video/fbdev/gbefb.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
index 1582c718329c..7e39ab939691 100644
--- a/drivers/video/fbdev/gbefb.c
+++ b/drivers/video/fbdev/gbefb.c
@@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device *p_dev)
platform_set_drvdata(p_dev, info);
- fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
- info->fix.id, gbe_revision, (unsigned)GBE_BASE,
- gbe_mem_size >> 10);
-
return 0;
out_gbe_unmap:
--
2.25.1
On 9/2/22 04:56, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the fb_info() should be removed.
NAK.
This seems to be useful info about the detected card and it's only
printed once.
Helge
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/video/fbdev/gbefb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 1582c718329c..7e39ab939691 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device *p_dev)
>
> platform_set_drvdata(p_dev, info);
>
> - fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
> - info->fix.id, gbe_revision, (unsigned)GBE_BASE,
> - gbe_mem_size >> 10);
> -
> return 0;
>
> out_gbe_unmap:
Hi
Am 25.09.22 um 13:24 schrieb Helge Deller:
> On 9/2/22 04:56, Jiasheng Jiang wrote:
>> When drivers are working properly, they are quiet.
>> Therefore, the fb_info() should be removed.
>
> NAK.
> This seems to be useful info about the detected card and it's only
> printed once.
Well, he has a point. Maybe this could become an fb_dbg() ? (BTW, it's
a bit unfortunate that there's an fb_info macro and an fb_info struct. :/)
Best regards
Thomas
>
> Helge
>
>> Signed-off-by: Jiasheng Jiang <[email protected]>
>> ---
>> drivers/video/fbdev/gbefb.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
>> index 1582c718329c..7e39ab939691 100644
>> --- a/drivers/video/fbdev/gbefb.c
>> +++ b/drivers/video/fbdev/gbefb.c
>> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device
>> *p_dev)
>>
>> platform_set_drvdata(p_dev, info);
>>
>> - fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
>> - info->fix.id, gbe_revision, (unsigned)GBE_BASE,
>> - gbe_mem_size >> 10);
>> -
>> return 0;
>>
>> out_gbe_unmap:
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev