2021-04-09 12:26:19

by Aline Santana Cordeiro

[permalink] [raw]
Subject: [Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Aligns line break with the remaining function arguments
to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <[email protected]>
---
Changes since v2:
- Rename the commit messages properly

Changes since v1:
- Send patchset without the cover-letter
- Rename the commit messages wrongly in the email subject only

drivers/staging/media/hantro/hantro_hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/hantro/hantro_hw.h b/drivers/staging/media/hantro/hantro_hw.h
index 34c9e46..a650b9c 100644
--- a/drivers/staging/media/hantro/hantro_hw.h
+++ b/drivers/staging/media/hantro/hantro_hw.h
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width, unsigned int height)
void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
- const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+ const struct v4l2_ctrl_mpeg2_quantization *ctrl);
int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);

--
2.7.4


2021-04-09 16:46:58

by Ezequiel Garcia

[permalink] [raw]
Subject: Re: [Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Hi Aline,

On Fri, 2021-04-09 at 09:24 -0300, Aline Santana Cordeiro wrote:
> Aligns line break with the remaining function arguments
> to the open parenthesis. Issue found by checkpatch.
>
> Signed-off-by: Aline Santana Cordeiro <[email protected]>
> ---
> Changes since v2:
>  - Rename the commit messages properly
>
> Changes since v1:
>  - Send patchset without the cover-letter

Why did you remove the cover letter? What was wrong with it?

Thanks!
Ezequiel

2021-04-09 17:33:01

by Aline Santana Cordeiro

[permalink] [raw]
Subject: Re: [Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Em sex, 2021-04-09 às 13:45 -0300, Ezequiel Garcia escreveu:
> Hi Aline,
Hi Ezequiel,
>
> On Fri, 2021-04-09 at 09:24 -0300, Aline Santana Cordeiro wrote:
> > Aligns line break with the remaining function arguments
> > to the open parenthesis. Issue found by checkpatch.
> >
> > Signed-off-by: Aline Santana Cordeiro <
> > [email protected]>
> > ---
> > Changes since v2:
> >  - Rename the commit messages properly
> >
> > Changes since v1:
> >  - Send patchset without the cover-letter
>
> Why did you remove the cover letter? What was wrong with it?

I got confused and as I used the same message as commit for the three
files - cover-letter, patch 1/2, and patch 2/2 - they were sent in only
one e-mail on patch 0/2, and the files modified weren't marked as patch
1/2 and patch 2/2, so I though it was wrong and sent v2 in a wrong way.

> Thanks!
> Ezequiel
>
Thank you!
Aline