2022-04-22 19:15:56

by Dave Jiang

[permalink] [raw]
Subject: Re: [PATCH] ntb_perf: fix doubletest cocci warning


On 4/19/2022 12:18 AM, Guo Zhengkui wrote:
> `!data->ops.init` has been repeated triple. The original logic is to
> check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
>
> Signed-off-by: Guo Zhengkui <[email protected]>

Reviewed-by: Dave Jiang <[email protected]>


> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index c106c3a5097e..dcae4be91365 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct *work)
> {
> struct perf_ext_lat_data *data = to_ext_lat_data(work);
>
> - if (!data->ops.init || !data->ops.init || !data->ops.init) {
> + if (!data->ops.init || !data->ops.run || !data->ops.clear) {
> struct perf_ctx *perf = data->perf;
>
> data->status = -EFAULT;