2021-11-08 10:18:02

by Chindris, Mihail

[permalink] [raw]
Subject: RE: [PATCH v5 1/2] dt-bindings: iio: dac: Add adi,ad3552r.yaml

...
> +patternProperties:
> + "^channel@([0-1])$":
> + type: object
> + description: Configurations of the DAC Channels
> + properties:
> + reg:
> + description: Channel number
> + enum: [0, 1]
> +
> + custom-output-range-config:

Copy unanswered comment from V3

> > >
> > > Not a generic property so I think this needs an adi prefix.
> > > Jonathan
> >
> > I tried with adi prefix but I get weird errors while running dt_binding_check for properties with adi prefix and with type:object
> > Do you have any suggestion for this issues?
> >
> > Mihail
> >
@Rob
Jonathan

> + type: object
> + description: Configuration of custom range when
> + adi,output-range-microvolt is not present.
> + The formulas for calculation the output voltages are
> + Vout_fs = 2.5 + [(GainN + Offset/1024) * 2.5 * Rfbx * 1.03]
> + Vout_zs = 2.5 - [(GainP + Offset/1024) * 2.5 * Rfbx * 1.03]
...


2021-11-08 12:01:04

by Lars-Peter Clausen

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: iio: dac: Add adi,ad3552r.yaml

On 11/8/21 9:29 AM, Chindris, Mihail wrote:
> ...
>> +patternProperties:
>> + "^channel@([0-1])$":
>> + type: object
>> + description: Configurations of the DAC Channels
>> + properties:
>> + reg:
>> + description: Channel number
>> + enum: [0, 1]
>> +
>> + custom-output-range-config:
> Copy unanswered comment from V3
>
>>>> Not a generic property so I think this needs an adi prefix.
>>>> Jonathan
>>> I tried with adi prefix but I get weird errors while running dt_binding_check for properties with adi prefix and with type:object
>>> Do you have any suggestion for this issues?
>>>
>>> Mihail
>>>
> @Rob
> Jonathan

I had the same problem with the bindings for the xadc driver:
https://www.spinics.net/lists/devicetree/msg382081.html


>> + type: object
>> + description: Configuration of custom range when
>> + adi,output-range-microvolt is not present.
>> + The formulas for calculation the output voltages are
>> + Vout_fs = 2.5 + [(GainN + Offset/1024) * 2.5 * Rfbx * 1.03]
>> + Vout_zs = 2.5 - [(GainP + Offset/1024) * 2.5 * Rfbx * 1.03]
> ...