2017-11-19 03:57:40

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 4/6 v2] mmc: sdhci-spear: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.

drivers/mmc/host/sdhci-spear.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c
index 8c0f884..900838b 100644
--- a/drivers/mmc/host/sdhci-spear.c
+++ b/drivers/mmc/host/sdhci-spear.c
@@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev)
host->hw_name = "sdhci";
host->ops = &sdhci_pltfm_ops;
host->irq = platform_get_irq(pdev, 0);
+ if (host->irq <= 0) {
+ ret = host->irq;
+ goto err_host;
+ }
host->quirks = SDHCI_QUIRK_BROKEN_ADMA;

sdhci = sdhci_priv(host);
--
2.7.4


From 1584562249422088781@xxx Mon Nov 20 05:38:40 +0000 2017
X-GM-THRID: 1584219345847479054
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread