2022-04-02 09:05:57

by Jakob Koschel

Subject: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
Signed-off-by: Jakob Koschel <[email protected]>
---
drivers/video/fbdev/mmp/core.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
index 154127256a2c..03707461eced 100644
--- a/drivers/video/fbdev/mmp/core.c
+++ b/drivers/video/fbdev/mmp/core.c
@@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
*/
struct mmp_path *mmp_get_path(const char *name)
{
- struct mmp_path *path;
- int found = 0;
+ struct mmp_path *path = NULL, *iter;

mutex_lock(&disp_lock);
- list_for_each_entry(path, &path_list, node) {
- if (!strcmp(name, path->name)) {
- found = 1;
+ list_for_each_entry(iter, &path_list, node) {
+ if (!strcmp(name, iter->name)) {
+ path = iter;
break;
}
}
mutex_unlock(&disp_lock);

- return found ? path : NULL;
+ return path;
}
EXPORT_SYMBOL_GPL(mmp_get_path);


base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275
--
2.25.1

2022-04-13 00:05:54

by Helge Deller

Subject: Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable

On 4/1/22 00:35, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <[email protected]>

applied.

Thanks!
Helge

> ---
> drivers/video/fbdev/mmp/core.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbdev/mmp/core.c b/drivers/video/fbdev/mmp/core.c
> index 154127256a2c..03707461eced 100644
> --- a/drivers/video/fbdev/mmp/core.c
> +++ b/drivers/video/fbdev/mmp/core.c
> @@ -127,19 +127,18 @@ EXPORT_SYMBOL_GPL(mmp_unregister_panel);
> */
> struct mmp_path *mmp_get_path(const char *name)
> {
> - struct mmp_path *path;
> - int found = 0;
> + struct mmp_path *path = NULL, *iter;
>
> mutex_lock(&disp_lock);
> - list_for_each_entry(path, &path_list, node) {
> - if (!strcmp(name, path->name)) {
> - found = 1;
> + list_for_each_entry(iter, &path_list, node) {
> + if (!strcmp(name, iter->name)) {
> + path = iter;
> break;
> }
> }
> mutex_unlock(&disp_lock);
>
> - return found ? path : NULL;
> + return path;
> }
> EXPORT_SYMBOL_GPL(mmp_get_path);
>
>
> base-commit: f82da161ea75dc4db21b2499e4b1facd36dab275