2019-04-19 18:25:17

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] net/mlx5e: remove meaningless CFLAGS_tracepoint.o

CFLAGS_tracepoint.o specifies CFLAGS for compiling tracepoint.c but
it does not exist under drivers/net/ethernet/mellanox/mlx5/core/.

CFLAGS_tracepoint.o is unused.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
index 1a16f6d73cbc..fa12c2ca9fc5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
+++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
@@ -57,5 +57,3 @@ mlx5_core-$(CONFIG_MLX5_EN_IPSEC) += en_accel/ipsec.o en_accel/ipsec_rxtx.o \
en_accel/ipsec_stats.o

mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/tls.o en_accel/tls_rxtx.o en_accel/tls_stats.o
-
-CFLAGS_tracepoint.o := -I$(src)
--
2.17.1



2019-04-19 23:17:45

by Saeed Mahameed

[permalink] [raw]
Subject: Re: [PATCH] net/mlx5e: remove meaningless CFLAGS_tracepoint.o

On Fri, 2019-04-19 at 14:17 +0900, Masahiro Yamada wrote:
> CFLAGS_tracepoint.o specifies CFLAGS for compiling tracepoint.c but
> it does not exist under drivers/net/ethernet/mellanox/mlx5/core/.
>
> CFLAGS_tracepoint.o is unused.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> index 1a16f6d73cbc..fa12c2ca9fc5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile
> @@ -57,5 +57,3 @@ mlx5_core-$(CONFIG_MLX5_EN_IPSEC) +=
> en_accel/ipsec.o en_accel/ipsec_rxtx.o \
> en_accel/ipsec_stats.o
>
> mlx5_core-$(CONFIG_MLX5_EN_TLS) += en_accel/tls.o
> en_accel/tls_rxtx.o en_accel/tls_stats.o
> -
> -CFLAGS_tracepoint.o := -I$(src)

LGTM, applied to mlx5 branch, will be sent upstream shortly.

Thanks,
Saeed.