2023-08-03 12:05:56

by Miaohe Lin

Subject: [PATCH] mm/page_alloc: remove unneeded variable base

Since commit 5d0a661d808f ("mm/page_alloc: use only one PCP list for
THP-sized allocations"), local variable base is just as same as order.
So remove it. No functional change intended.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/page_alloc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index d7a357cb21ee..96b7c1a7d1f2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -538,8 +538,6 @@ static void bad_page(struct page *page, const char *reason)

static inline unsigned int order_to_pindex(int migratetype, int order)
{
- int base = order;
-
#ifdef CONFIG_TRANSPARENT_HUGEPAGE
if (order > PAGE_ALLOC_COSTLY_ORDER) {
VM_BUG_ON(order != pageblock_order);
@@ -549,7 +547,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order)
VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER);
#endif

- return (MIGRATE_PCPTYPES * base) + migratetype;
+ return (MIGRATE_PCPTYPES * order) + migratetype;
}

static inline int pindex_to_order(unsigned int pindex)
--
2.33.0

2023-08-03 14:10:11

by David Hildenbrand

Subject: Re: [PATCH] mm/page_alloc: remove unneeded variable base

On 03.08.23 13:49, Miaohe Lin wrote:
> Since commit 5d0a661d808f ("mm/page_alloc: use only one PCP list for
> THP-sized allocations"), local variable base is just as same as order.
> So remove it. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/page_alloc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index d7a357cb21ee..96b7c1a7d1f2 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -538,8 +538,6 @@ static void bad_page(struct page *page, const char *reason)
>
> static inline unsigned int order_to_pindex(int migratetype, int order)
> {
> - int base = order;
> -
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> if (order > PAGE_ALLOC_COSTLY_ORDER) {
> VM_BUG_ON(order != pageblock_order);
> @@ -549,7 +547,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order)
> VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER);
> #endif
>
> - return (MIGRATE_PCPTYPES * base) + migratetype;
> + return (MIGRATE_PCPTYPES * order) + migratetype;
> }
>
> static inline int pindex_to_order(unsigned int pindex)

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb