2022-04-22 02:24:54

by Takashi Iwai

Subject: [PATCH 3/5] selftests: firmware: Fix the request_firmware_into_buf() test for XZ format

The test uses a different firmware name, and we forgot to adapt for
the XZ compressed file tests.

Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests")
https://lore.kernel.org/all/[email protected]/
Signed-off-by: Takashi Iwai <[email protected]>
---
tools/testing/selftests/firmware/fw_filesystem.sh | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
index 731f011def78..3ac09b401a83 100755
--- a/tools/testing/selftests/firmware/fw_filesystem.sh
+++ b/tools/testing/selftests/firmware/fw_filesystem.sh
@@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0

# test with both files present
$RUN_XZ -k $FW
+$RUN_XZ -k $FW_INTO_BUF
config_set_name $NAME
echo
echo "Testing with both plain and xz files present..."
@@ -529,6 +530,7 @@ done

# test with only xz file present
mv "$FW" "${FW}-orig"
+mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig"
echo
echo "Testing with only xz file present..."
for i in $(seq 1 5); do
--
2.31.1

2022-04-27 11:15:00

by Shuah Khan

Subject: Re: [PATCH 3/5] selftests: firmware: Fix the request_firmware_into_buf() test for XZ format

On 4/21/22 9:29 AM, Takashi Iwai wrote:
> The test uses a different firmware name, and we forgot to adapt for
> the XZ compressed file tests.
>
> Fixes: 1798045900b7 ("selftests: firmware: Add request_firmware_into_buf tests")
> https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Takashi Iwai <[email protected]>
> ---
> tools/testing/selftests/firmware/fw_filesystem.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> index 731f011def78..3ac09b401a83 100755
> --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> @@ -504,6 +504,7 @@ test "$HAS_FW_LOADER_COMPRESS" != "yes" && exit 0
>
> # test with both files present
> $RUN_XZ -k $FW
> +$RUN_XZ -k $FW_INTO_BUF
> config_set_name $NAME
> echo
> echo "Testing with both plain and xz files present..."
> @@ -529,6 +530,7 @@ done
>
> # test with only xz file present
> mv "$FW" "${FW}-orig"
> +mv "$FW_INTO_BUF" "${FW_INTO_BUF}-orig"
> echo
> echo "Testing with only xz file present..."
> for i in $(seq 1 5); do
>

Thank you. Looks good to me.

Reviewed-by: Shuah Khan <[email protected]>

thanks,
-- Shuah