2021-02-05 06:36:23

by Tiezhu Yang

Subject: [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c

When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.

Signed-off-by: Tiezhu Yang <[email protected]>
---
tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
index ad41ea6..e704181 100644
--- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
+++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
@@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)

if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
ksft_print_msg(
- "ptrace(PTRACE_SINGLESTEP) failed: %s\n",
+ "ptrace(PTRACE_CONT) failed: %s\n",
strerror(errno));
return false;
}
@@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
}
alarm(0);
if (WIFEXITED(status)) {
- ksft_print_msg("child did not single-step\n");
+ ksft_print_msg("child exited prematurely\n");
return false;
}
if (!WIFSTOPPED(status)) {
--
2.1.0

2021-02-09 00:10:03

by Shuah Khan

Subject: Re: [PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c

On 2/4/21 11:33 PM, Tiezhu Yang wrote:
> When call ptrace(PTRACE_CONT, ...) failed, use correct error messages.
>
> Signed-off-by: Tiezhu Yang <[email protected]>
> ---
> tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index ad41ea6..e704181 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -145,7 +145,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
>
> if (ptrace(PTRACE_CONT, pid, NULL, NULL) < 0) {
> ksft_print_msg(
> - "ptrace(PTRACE_SINGLESTEP) failed: %s\n",
> + "ptrace(PTRACE_CONT) failed: %s\n",
> strerror(errno));
> return false;
> }
> @@ -159,7 +159,7 @@ static bool run_test(int wr_size, int wp_size, int wr, int wp)
> }
> alarm(0);
> if (WIFEXITED(status)) {
> - ksft_print_msg("child did not single-step\n");
> + ksft_print_msg("child exited prematurely\n");
> return false;
> }
> if (!WIFSTOPPED(status)) {
>

Thank you. Applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah