2018-07-16 13:02:19

by Haakon Bugge

Subject: [PATCH] net/rds: void function cannot return -1

Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
not change the comment accordingly.

Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
Signed-off-by: Håkon Bugge <[email protected]>
---
net/rds/ib_recv.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index b4e421aa9727..e5ce93419263 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
* This tries to allocate and post unused work requests after making sure that
* they have all the allocations they need to queue received fragments into
* sockets.
- *
- * -1 is returned if posting fails due to temporary resource exhaustion.
*/
void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
{
--
2.14.3

2018-07-16 16:30:09

by Santosh Shilimkar

Subject: Re: [PATCH] net/rds: void function cannot return -1

On 7/16/2018 6:00 AM, Håkon Bugge wrote:
> Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
> not change the comment accordingly.
>
> Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
> Signed-off-by: Håkon Bugge <[email protected]>
> ---
> net/rds/ib_recv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
> index b4e421aa9727..e5ce93419263 100644
> --- a/net/rds/ib_recv.c
> +++ b/net/rds/ib_recv.c
> @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
> * This tries to allocate and post unused work requests after making sure that
> * they have all the allocations they need to queue received fragments into
> * sockets.
> - *
> - * -1 is returned if posting fails due to temporary resource exhaustion.
> */
> void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
> {
>
Yep. Thanks !!

Acked-by: Santosh Shilimkar <[email protected]>

2018-07-18 05:45:17

by David Miller

Subject: Re: [PATCH] net/rds: void function cannot return -1

From: H?kon Bugge <[email protected]>
Date: Mon, 16 Jul 2018 15:00:09 +0200

> Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
> not change the comment accordingly.
>
> Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
> Signed-off-by: H?kon Bugge <[email protected]>

Applied.