2021-06-02 21:51:14

by Kees Cook

Subject: [PATCH] acpi/arm64: Mark next_platform_timer as __init

Fix section mismatch warning:

WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
The function next_platform_timer() references
the variable __initdata acpi_gtdt_desc.
This is often because next_platform_timer lacks a __initdata
annotation or the annotation of acpi_gtdt_desc is wrong.

Suggested-by: Hanjun Guo <[email protected]>
Link: https://lore.kernel.org/linux-acpi/[email protected]/
Signed-off-by: Kees Cook <[email protected]>
---
drivers/acpi/arm64/gtdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
index 0a0a982f9c28..c3ad42470a7c 100644
--- a/drivers/acpi/arm64/gtdt.c
+++ b/drivers/acpi/arm64/gtdt.c
@@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {

static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;

-static inline void *next_platform_timer(void *platform_timer)
+static __init void *next_platform_timer(void *platform_timer)
{
struct acpi_gtdt_header *gh = platform_timer;

--
2.25.1

2021-06-03 02:02:58

by Hanjun Guo

Subject: Re: [PATCH] acpi/arm64: Mark next_platform_timer as __init

On 2021/6/3 5:46, Kees Cook wrote:
> Fix section mismatch warning:
>
> WARNING: modpost: vmlinux.o(.text.unlikely+0x95ac): Section mismatch in reference from the function next_platform_timer() to the variable .init.data:acpi_gtdt_desc
> The function next_platform_timer() references
> the variable __initdata acpi_gtdt_desc.
> This is often because next_platform_timer lacks a __initdata
> annotation or the annotation of acpi_gtdt_desc is wrong.
>
> Suggested-by: Hanjun Guo <[email protected]>
> Link: https://lore.kernel.org/linux-acpi/[email protected]/
> Signed-off-by: Kees Cook <[email protected]>
> ---
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 0a0a982f9c28..c3ad42470a7c 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
>
> static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
>
> -static inline void *next_platform_timer(void *platform_timer)
> +static __init void *next_platform_timer(void *platform_timer)
> {
> struct acpi_gtdt_header *gh = platform_timer;

Thanks for the fix,

Reviewed-by: Hanjun Guo <[email protected]>