2024-03-25 17:40:14

by Guenter Roeck

Subject: Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version of __assign_bit()

On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote:
> The newly introduced SWAP() macro is quite generic by naming, but
> moreover it's a repetition of the existing __assign_bit().
> With this applied, add a missing bits.h (via now required bitops.h).
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Not sure if I like __assign_bit() more than SWAP(), but at least it is
"standard". Applied.

Thanks,
Guenter

2024-03-25 20:19:11

by Andy Shevchenko

Subject: Re: [PATCH v1 1/3] hwmon: (pmbus/mp2975) Replace home made version of __assign_bit()

On Mon, Mar 25, 2024 at 09:29:11AM -0700, Guenter Roeck wrote:
> On Mon, Mar 25, 2024 at 02:07:42PM +0200, Andy Shevchenko wrote:
> > The newly introduced SWAP() macro is quite generic by naming, but
> > moreover it's a repetition of the existing __assign_bit().
> > With this applied, add a missing bits.h (via now required bitops.h).
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Not sure if I like __assign_bit() more than SWAP(),

To add to the mess, we have swap() already defined globally.
This one steps on our toes.

> but at least it is "standard". Applied.

Thank you!

--
With Best Regards,
Andy Shevchenko