2019-09-23 14:58:27

by Markus Elfring

Subject: [PATCH] drm/bridge/synopsys: dsi: Use devm_platform_ioremap_resource() in __dw_mipi_dsi_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 21 Sep 2019 20:04:08 +0200

Simplify this function implementation by using a known wrapper function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 675442bfc1bd..6ada149af9ef 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -981,7 +981,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
struct device *dev = &pdev->dev;
struct reset_control *apb_rst;
struct dw_mipi_dsi *dsi;
- struct resource *res;
int ret;

dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
@@ -997,11 +996,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
}

if (!plat_data->base) {
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return ERR_PTR(-ENODEV);
-
- dsi->base = devm_ioremap_resource(dev, res);
+ dsi->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(dsi->base))
return ERR_PTR(-ENODEV);

--
2.23.0

2019-09-26 09:21:53

by Andrzej Hajda

Subject: Re: [PATCH] drm/bridge/synopsys: dsi: Use devm_platform_ioremap_resource() in __dw_mipi_dsi_probe()

Hi Yannick, Markus.

On 23.09.2019 11:05, Yannick FERTRE wrote:
> Reviewed-by: Yannick Fertré <[email protected]>
> Tested-by: Yannick Fertré <[email protected]>


Yannick, next time could you put your tags after tags of the patch,
otherwise patchwork is confused and creates incorrect patches [1].

[1]: https://patchwork.freedesktop.org/patch/332360/


> Best regards
>
> --
> Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33
> 620600270
> Microcontrollers and Digital ICs Group | Microcontrolleurs Division
>
>
> On 9/21/19 8:20 PM, Markus Elfring wrote:
>> From: Markus Elfring <[email protected]>
>> Date: Sat, 21 Sep 2019 20:04:08 +0200
>>
>> Simplify this function implementation by using a known wrapper function.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <[email protected]>


I meant here :)


Anyway, patch queued.


Regards

Andrzej



>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> index 675442bfc1bd..6ada149af9ef 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>> @@ -981,7 +981,6 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>> struct device *dev = &pdev->dev;
>> struct reset_control *apb_rst;
>> struct dw_mipi_dsi *dsi;
>> - struct resource *res;
>> int ret;
>>
>> dsi = devm_kzalloc(dev, sizeof(*dsi), GFP_KERNEL);
>> @@ -997,11 +996,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
>> }
>>
>> if (!plat_data->base) {
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res)
>> - return ERR_PTR(-ENODEV);
>> -
>> - dsi->base = devm_ioremap_resource(dev, res);
>> + dsi->base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(dsi->base))
>> return ERR_PTR(-ENODEV);
>>
>> --
>> 2.23.0
>>
>