2021-09-20 16:04:44

by Neil Armstrong

Subject: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

From: Gowtham Tammana <[email protected]>

BB2D is a Vivante GC 2D Accelerator.
This adds the node to the dts file within a target module node.
Crossbar index number is used for interrupt mapping.

Signed-off-by: Gowtham Tammana <[email protected]>
Signed-off-by: Jyri Sarha <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm/boot/dts/dra7.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index dfc1ef8ef6ae..8a9df5ed5439 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -965,6 +965,26 @@ hdmi: encoder@0 {
};
};

+ target-module@59000000 {
+ compatible = "ti,sysc-omap4", "ti,sysc";
+ reg = <0x59000020 0x4>;
+ reg-names = "rev";
+ clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
+ clock-names = "fck";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x59000000 0x1000>;
+
+ bb2d: gpu@0 {
+ compatible = "vivante,gc";
+ reg = <0x0 0x0700>;
+ interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
+ clock-names = "core";
+ status = "disabled";
+ };
+ };
+
aes1_target: target-module@4b500000 {
compatible = "ti,sysc-omap2", "ti,sysc";
reg = <0x4b500080 0x4>,
--
2.25.1

2021-09-21 00:04:07

by Neil Armstrong

Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

On 20/09/2021 15:37, Tony Lindgren wrote:
> Hi,
>
> * Neil Armstrong <[email protected]> [210920 12:53]:
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
>> };
>> };
>>
>> + target-module@59000000 {
>> + compatible = "ti,sysc-omap4", "ti,sysc";
>> + reg = <0x59000020 0x4>;
>> + reg-names = "rev";
>> + clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
>> + clock-names = "fck";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges = <0x0 0x59000000 0x1000>;
>> +
>> + bb2d: gpu@0 {
>> + compatible = "vivante,gc";
>> + reg = <0x0 0x0700>;
>> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
>> + clock-names = "core";
>> + status = "disabled";
>> + };
>> + };
>> +
>> aes1_target: target-module@4b500000 {
>> compatible = "ti,sysc-omap2", "ti,sysc";
>> reg = <0x4b500080 0x4>,
>
> How about just use the default for the bb2d node with is "okay"?
> That way there's no need set status = "okay" for each board file.
>
> If there is no driver loaded, we idle the target-module anyways.

Yes you're right, I'll resend only this patch with no status property on bb2d node.

thanks,
Neil

>
> Regards,
>
> Tony
>

2021-09-21 00:23:57

by Tony Lindgren

Subject: Re: [PATCH 1/4] ARM: dts: dra7: add entry for bb2d module

Hi,

* Neil Armstrong <[email protected]> [210920 12:53]:
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -965,6 +965,26 @@ hdmi: encoder@0 {
> };
> };
>
> + target-module@59000000 {
> + compatible = "ti,sysc-omap4", "ti,sysc";
> + reg = <0x59000020 0x4>;
> + reg-names = "rev";
> + clocks = <&dss_clkctrl DRA7_DSS_BB2D_CLKCTRL 0>;
> + clock-names = "fck";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x59000000 0x1000>;
> +
> + bb2d: gpu@0 {
> + compatible = "vivante,gc";
> + reg = <0x0 0x0700>;
> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&dss_clkctrl DRA7_BB2D_CLKCTRL 0>;
> + clock-names = "core";
> + status = "disabled";
> + };
> + };
> +
> aes1_target: target-module@4b500000 {
> compatible = "ti,sysc-omap2", "ti,sysc";
> reg = <0x4b500080 0x4>,

How about just use the default for the bb2d node with is "okay"?
That way there's no need set status = "okay" for each board file.

If there is no driver loaded, we idle the target-module anyways.

Regards,

Tony