2022-10-31 10:37:26

by Claudiu Beznea

[permalink] [raw]
Subject: Re: [PATCHv1 3/8] ARM: dts: at91: sam9x60: Add flexcom definitions

On 31.10.2022 05:36, Durai Manickam KR wrote:
> Add the flexcom definitions to the SoC specifc DTSI file.
>
> Signed-off-by: Durai Manickam KR <[email protected]>
> Signed-off-by: Hari Prasath <[email protected]>
> Signed-off-by: Manikandan M <[email protected]>

For a cleaner view you can use [] to specify each ones contribution. See
https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

> ---
> arch/arm/boot/dts/sam9x60.dtsi | 52 ++++++++++++++++++++++++++++++++--
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
> index ef07d281a3db..fd4f5d43f7bb 100644
> --- a/arch/arm/boot/dts/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/sam9x60.dtsi
> @@ -170,6 +170,16 @@ flx4: flexcom@f0000000 {
> #size-cells = <1>;
> ranges = <0x0 0xf0000000 0x800>;
> status = "disabled";
> +
> + spi4: spi@400 {
> + compatible = "microchip,sam9x60-spi", "atmel,at91rm9200-spi";
> + reg = <0x400 0x200>;
> + interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>;
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 13>;
> + clock-names = "spi_clk";
> + atmel,fifo-size = <16>;
> + status = "disabled";
> + };
> };
>
> flx5: flexcom@f0004000 {
> @@ -180,6 +190,26 @@ flx5: flexcom@f0004000 {
> #size-cells = <1>;
> ranges = <0x0 0xf0004000 0x800>;
> status = "disabled";
> +
> + uart5: serial@200 {
> + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart";
> + reg = <0x200 0x200>;
> + interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>;
> + dmas = <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) |
> + AT91_XDMAC_DT_PER_IF(1) |
> + AT91_XDMAC_DT_PERID(10))>,
> + <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) |
> + AT91_XDMAC_DT_PER_IF(1) |
> + AT91_XDMAC_DT_PERID(11))>;
> + dma-names = "tx", "rx";
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 14>;
> + clock-names = "usart";
> + atmel,use-dma-rx;
> + atmel,use-dma-tx;
> + status = "disabled";
> + };
> };
>
> dma0: dma-controller@f0008000 {
> @@ -390,6 +420,15 @@ flx6: flexcom@f8010000 {
> #size-cells = <1>;
> ranges = <0x0 0xf8010000 0x800>;
> status = "disabled";
> +
> + i2c6: i2c@600 {
> + compatible = "microchip,sam9x60-i2c";
> + reg = <0x600 0x200>;
> + interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>;
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 9>;
> + atmel,fifo-size = <16>;
> + status = "disabled";
> + };
> };
>
> flx7: flexcom@f8014000 {
> @@ -416,10 +455,19 @@ flx0: flexcom@f801c000 {
> compatible = "atmel,sama5d2-flexcom";
> reg = <0xf801c000 0x200>;
> clocks = <&pmc PMC_TYPE_PERIPHERAL 5>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> ranges = <0x0 0xf801c000 0x800>;
> status = "disabled";
> +
> + i2c0: i2c@600 {
> + compatible = "microchip,sam9x60-i2c";
> + reg = <0x600 0x200>;
> + interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 5>;
> + atmel,fifo-size = <16>;
> + status = "disabled";
> + };
> };
>
> flx1: flexcom@f8020000 {