2014-04-03 14:50:55

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH] cpufreq: at32ap: don't declare local variable as static

Earlier commit:
commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
Author: Viresh Kumar <[email protected]>
Date: Thu Jan 9 20:38:43 2014 +0530

cpufreq: introduce cpufreq_generic_get() routine

did some changes to driver and by mistake made cpuclk as a 'static' local
variable, which wasn't actually required. Fix it.

Reported-by: Alexandre Oliva <[email protected]>
Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/cpufreq/at32ap-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
index a1c79f5..7b612c8 100644
--- a/drivers/cpufreq/at32ap-cpufreq.c
+++ b/drivers/cpufreq/at32ap-cpufreq.c
@@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
{
unsigned int frequency, rate, min_freq;
- static struct clk *cpuclk;
+ struct clk *cpuclk;
int retval, steps, i;

if (policy->cpu != 0)
--
1.7.12.rc2.18.g61b472e


Subject: Re: [PATCH] cpufreq: at32ap: don't declare local variable as static

Around Thu 03 Apr 2014 20:20:36 +0530 or thereabout, Viresh Kumar wrote:
> Earlier commit:
> commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
> Author: Viresh Kumar <[email protected]>
> Date: Thu Jan 9 20:38:43 2014 +0530
>
> cpufreq: introduce cpufreq_generic_get() routine
>
> did some changes to driver and by mistake made cpuclk as a 'static' local
> variable, which wasn't actually required. Fix it.
>
> Reported-by: Alexandre Oliva <[email protected]>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Hans-Christian Egtvedt <[email protected]>

> ---
> drivers/cpufreq/at32ap-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
> index a1c79f5..7b612c8 100644
> --- a/drivers/cpufreq/at32ap-cpufreq.c
> +++ b/drivers/cpufreq/at32ap-cpufreq.c
> @@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
> static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
> {
> unsigned int frequency, rate, min_freq;
> - static struct clk *cpuclk;
> + struct clk *cpuclk;
> int retval, steps, i;
>
> if (policy->cpu != 0)
--
Hans-Christian Egtvedt

2014-04-08 11:56:48

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] cpufreq: at32ap: don't declare local variable as static

On Thursday, April 03, 2014 08:20:36 PM Viresh Kumar wrote:
> Earlier commit:
> commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
> Author: Viresh Kumar <[email protected]>
> Date: Thu Jan 9 20:38:43 2014 +0530
>
> cpufreq: introduce cpufreq_generic_get() routine
>
> did some changes to driver and by mistake made cpuclk as a 'static' local
> variable, which wasn't actually required. Fix it.
>
> Reported-by: Alexandre Oliva <[email protected]>
> Signed-off-by: Viresh Kumar <[email protected]>

Queued up for the next pull request, thanks!

> ---
> drivers/cpufreq/at32ap-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
> index a1c79f5..7b612c8 100644
> --- a/drivers/cpufreq/at32ap-cpufreq.c
> +++ b/drivers/cpufreq/at32ap-cpufreq.c
> @@ -52,7 +52,7 @@ static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
> static int at32_cpufreq_driver_init(struct cpufreq_policy *policy)
> {
> unsigned int frequency, rate, min_freq;
> - static struct clk *cpuclk;
> + struct clk *cpuclk;
> int retval, steps, i;
>
> if (policy->cpu != 0)
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.