2022-07-11 11:23:10

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC

Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on
Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXS ||
ARCH_MXC, to prevent asking the user about this driver when configuring
a kernel without Freescale/NXP i.MX support.

Fixes: 45d59d704080cc0c ("drm: Add new driver for MXSFB controller")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/gpu/drm/mxsfb/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig
index 873551b4552f5023..02cf19fcef315724 100644
--- a/drivers/gpu/drm/mxsfb/Kconfig
+++ b/drivers/gpu/drm/mxsfb/Kconfig
@@ -8,6 +8,7 @@ config DRM_MXSFB
tristate "i.MX (e)LCDIF LCD controller"
depends on DRM && OF
depends on COMMON_CLK
+ depends on ARCH_MXS || ARCH_MXC || COMPILE_TEST
select DRM_MXS
select DRM_KMS_HELPER
select DRM_GEM_CMA_HELPER
--
2.25.1


2022-07-11 11:24:55

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 1/2] drm: mxsfb: DRM_MXSFB should depend on ARCH_MXS || ARCH_MXC

On 7/11/22 11:01, Geert Uytterhoeven wrote:
> Freescale/NXP i.MX LCDIF and eLCDIF LCD controllers are only present on
> Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXS ||
> ARCH_MXC, to prevent asking the user about this driver when configuring
> a kernel without Freescale/NXP i.MX support.
>
> Fixes: 45d59d704080cc0c ("drm: Add new driver for MXSFB controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Is the Fixes tag really justified in this case ?

Otherwise

Reviewed-by: Marek Vasut <[email protected]>

2022-07-11 11:40:00

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC

The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on
Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXC, to prevent
asking the user about this driver when configuring a kernel without
Freescale/NXP i.MX support.

Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/gpu/drm/mxsfb/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig
index 02cf19fcef315724..40cc9b8fb749f3e4 100644
--- a/drivers/gpu/drm/mxsfb/Kconfig
+++ b/drivers/gpu/drm/mxsfb/Kconfig
@@ -25,6 +25,7 @@ config DRM_IMX_LCDIF
tristate "i.MX LCDIFv3 LCD controller"
depends on DRM && OF
depends on COMMON_CLK
+ depends on ARCH_MXC || COMPILE_TEST
select DRM_MXS
select DRM_KMS_HELPER
select DRM_GEM_CMA_HELPER
--
2.25.1

2022-07-11 11:42:00

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 2/2] drm: mxsfb: DRM_IMX_LCDIF should depend on ARCH_MXC

On 7/11/22 11:01, Geert Uytterhoeven wrote:
> The Freescale/NXP i.MX LCDIFv3 LCD controller is only present on
> Freescale/NXP i.MX SoCs. Hence add a dependency on ARCH_MXC, to prevent
> asking the user about this driver when configuring a kernel without
> Freescale/NXP i.MX support.
>
> Fixes: 9db35bb349a0ef32 ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Marek Vasut <[email protected]>