2016-10-05 02:08:09

by Adam Ford

[permalink] [raw]
Subject: [PATCH V2] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies

Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
and SOC_OMAP5/DRA7XX respectively.

Signed-off-by: Adam Ford <[email protected]>

Changes in v2: Add dependancy for DRA7XX or OMAP5

diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig b/drivers/gpu/drm/omapdrm/dss/Kconfig
index d1fa730..befdd7a 100644
--- a/drivers/gpu/drm/omapdrm/dss/Kconfig
+++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
@@ -69,13 +69,15 @@ config OMAP2_DSS_HDMI_COMMON

config OMAP4_DSS_HDMI
bool "HDMI support for OMAP4"
- default y
+ depends on ARCH_OMAP4
+ default y
select OMAP2_DSS_HDMI_COMMON
help
HDMI support for OMAP4 based SoCs.

config OMAP5_DSS_HDMI
bool "HDMI support for OMAP5"
+ depends on SOC_OMAP5 || SOC_DRA7XX
default n
select OMAP2_DSS_HDMI_COMMON
help
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
index 27d2202..19e2e7b 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
+++ b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
@@ -65,13 +65,15 @@ config FB_OMAP2_DSS_HDMI_COMMON

config FB_OMAP4_DSS_HDMI
bool "HDMI support for OMAP4"
- default y
+ depends on ARCH_OMAP4
+ default y
select FB_OMAP2_DSS_HDMI_COMMON
help
HDMI support for OMAP4 based SoCs.

config FB_OMAP5_DSS_HDMI
bool "HDMI support for OMAP5"
+ depends on SOC_OMAP5 || SOC_DRA7XX
default n
select FB_OMAP2_DSS_HDMI_COMMON
help
--
2.7.4


2016-10-05 06:06:25

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH V2] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies

On 05/10/16 05:07, Adam Ford wrote:
> Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
> and SOC_OMAP5/DRA7XX respectively.
>
> Signed-off-by: Adam Ford <[email protected]>
>
> Changes in v2: Add dependancy for DRA7XX or OMAP5

You don't say it, but I presume this is just to make those kconfig
options disappear automatically if you don't have the specific ARCH_*
enabled?

I don't like these, as they will just clutter the Kconfig file. Here you
only added a few dependencies, but there are a lot more. VENC is only
there for some SoC versions, SDI is there only for some, same for
RFBI... And with every new SoC type we'd need to update all these.

Just disable the HDMI from the Kconfig if you don't want it included.

Tomi

Attachments:
signature.asc (819.00 B)
OpenPGP digital signature