2021-04-09 09:44:21

by Ye Bin

Subject: [PATCH -next] dlm: use DEFINE_MUTEX() for mutex lock

mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Ye Bin <[email protected]>
---
fs/dlm/lockspace.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index c14cf2b7faab..fa3ae801aa43 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -26,7 +26,7 @@
#include "ast.h"

static int ls_count;
-static struct mutex ls_lock;
+static DEFINE_MUTEX(ls_lock);
static struct list_head lslist;
static spinlock_t lslist_lock;
static struct task_struct * scand_task;
@@ -231,7 +231,6 @@ static const struct kset_uevent_ops dlm_uevent_ops = {
int __init dlm_lockspace_init(void)
{
ls_count = 0;
- mutex_init(&ls_lock);
INIT_LIST_HEAD(&lslist);
spin_lock_init(&lslist_lock);

2021-04-09 09:51:57

by Wei Yongjun

Subject: Re: [PATCH -next] dlm: use DEFINE_MUTEX() for mutex lock

????????һ???Ŀ??Ժϲ?

?? 2021/4/9 17:51, Ye Bin д??:
> mutex lock can be initialized automatically with DEFINE_MUTEX()
> rather than explicitly calling mutex_init().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Ye Bin <[email protected]>
> ---
> fs/dlm/lockspace.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
> index c14cf2b7faab..fa3ae801aa43 100644
> --- a/fs/dlm/lockspace.c
> +++ b/fs/dlm/lockspace.c
> @@ -26,7 +26,7 @@
> #include "ast.h"
>
> static int ls_count;
> -static struct mutex ls_lock;
> +static DEFINE_MUTEX(ls_lock);
> static struct list_head lslist;
> static spinlock_t lslist_lock;
> static struct task_struct * scand_task;
> @@ -231,7 +231,6 @@ static const struct kset_uevent_ops dlm_uevent_ops = {
> int __init dlm_lockspace_init(void)
> {
> ls_count = 0;
> - mutex_init(&ls_lock);
> INIT_LIST_HEAD(&lslist);
> spin_lock_init(&lslist_lock);
>
>