2021-04-29 09:08:07

by Jerome Brunet

Subject: [PATCH] clk: meson: axg-audio: do not print error on defer

Do not print an error if we are just waiting for the reset controller to
come up.

Signed-off-by: Jerome Brunet <[email protected]>
---
drivers/clk/meson/axg-audio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
index 7c8d02164443..5e501eff0840 100644
--- a/drivers/clk/meson/axg-audio.c
+++ b/drivers/clk/meson/axg-audio.c
@@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)

ret = device_reset(dev);
if (ret) {
- dev_err(dev, "failed to reset device\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "failed to reset device\n");
return ret;
}

--
2.31.1

2021-04-29 09:24:50

by Neil Armstrong

Subject: Re: [PATCH] clk: meson: axg-audio: do not print error on defer

On 29/04/2021 11:05, Jerome Brunet wrote:
> Do not print an error if we are just waiting for the reset controller to
> come up.
>
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
> drivers/clk/meson/axg-audio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
> index 7c8d02164443..5e501eff0840 100644
> --- a/drivers/clk/meson/axg-audio.c
> +++ b/drivers/clk/meson/axg-audio.c
> @@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
>
> ret = device_reset(dev);
> if (ret) {
> - dev_err(dev, "failed to reset device\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to reset device\n");
> return ret;
> }
>
>

Reviewed-by: Neil Armstrong <[email protected]>

2021-04-29 20:51:08

by Martin Blumenstingl

Subject: Re: [PATCH] clk: meson: axg-audio: do not print error on defer

Hi Jerome,

On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
[...]
> diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
> index 7c8d02164443..5e501eff0840 100644
> --- a/drivers/clk/meson/axg-audio.c
> +++ b/drivers/clk/meson/axg-audio.c
> @@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
>
> ret = device_reset(dev);
> if (ret) {
> - dev_err(dev, "failed to reset device\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to reset device\n");
many drivers are switching to dev_err_probe nowadays
According to it's documentation:
In case of -EPROBE_DEFER it sets also defer probe reason, which can be
checked later by reading devices_deferred debugfs attribute.

so I think it makes sense to use dev_err_probe here as well


Best regards,
Martin

2021-04-30 02:03:41

by Stephen Boyd

Subject: Re: [PATCH] clk: meson: axg-audio: do not print error on defer

Quoting Martin Blumenstingl (2021-04-29 13:49:54)
> Hi Jerome,
>
> On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
> [...]
> > diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
> > index 7c8d02164443..5e501eff0840 100644
> > --- a/drivers/clk/meson/axg-audio.c
> > +++ b/drivers/clk/meson/axg-audio.c
> > @@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
> >
> > ret = device_reset(dev);
> > if (ret) {
> > - dev_err(dev, "failed to reset device\n");
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(dev, "failed to reset device\n");
> many drivers are switching to dev_err_probe nowadays
> According to it's documentation:
> In case of -EPROBE_DEFER it sets also defer probe reason, which can be
> checked later by reading devices_deferred debugfs attribute.
>
> so I think it makes sense to use dev_err_probe here as well
>
>

Yes please use dev_err_probe()

2021-04-30 08:03:54

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: axg-audio: do not print error on defer

On Thu 29 Apr 2021 at 22:49, Martin Blumenstingl <[email protected]> wrote:

> Hi Jerome,
>
> On Thu, Apr 29, 2021 at 11:06 AM Jerome Brunet <[email protected]> wrote:
> [...]
>> diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c
>> index 7c8d02164443..5e501eff0840 100644
>> --- a/drivers/clk/meson/axg-audio.c
>> +++ b/drivers/clk/meson/axg-audio.c
>> @@ -1811,7 +1811,8 @@ static int axg_audio_clkc_probe(struct platform_device *pdev)
>>
>> ret = device_reset(dev);
>> if (ret) {
>> - dev_err(dev, "failed to reset device\n");
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(dev, "failed to reset device\n");
> many drivers are switching to dev_err_probe nowadays
> According to it's documentation:
> In case of -EPROBE_DEFER it sets also defer probe reason, which can be
> checked later by reading devices_deferred debugfs attribute.
>
> so I think it makes sense to use dev_err_probe here as well

Old habits ;) thanks for pointing this out. Will do

>
>
> Best regards,
> Martin