2022-08-01 03:08:19

by Samuel Holland

Subject: [PATCH 1/9] dt-bindings: sram: sunxi-sram: Add D1 compatible string

D1 needs to export a register for managing some LDO regulators, so it
needs a unique compatible.

Signed-off-by: Samuel Holland <[email protected]>
---

.../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
index 1c426c211e36..ab6e95a97c9f 100644
--- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
+++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
@@ -39,6 +39,7 @@ properties:
- items:
- const: allwinner,sun8i-r40-system-control
- const: allwinner,sun4i-a10-system-control
+ - const: allwinner,sun20i-d1-system-control
- const: allwinner,sun50i-a64-sram-controller
deprecated: true
- const: allwinner,sun50i-a64-system-control
--
2.35.1

2022-08-02 09:36:04

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/9] dt-bindings: sram: sunxi-sram: Add D1 compatible string

On 01/08/2022 05:05, Samuel Holland wrote:
> D1 needs to export a register for managing some LDO regulators, so it
> needs a unique compatible.
>
> Signed-off-by: Samuel Holland <[email protected]>
> ---
>
> .../bindings/sram/allwinner,sun4i-a10-system-control.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index 1c426c211e36..ab6e95a97c9f 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -39,6 +39,7 @@ properties:
> - items:
> - const: allwinner,sun8i-r40-system-control
> - const: allwinner,sun4i-a10-system-control
> + - const: allwinner,sun20i-d1-system-control
> - const: allwinner,sun50i-a64-sram-controller
> deprecated: true
> - const: allwinner,sun50i-a64-system-control

Please first clean up the compatible list. All these should be one enum.
You have duplicated entries for two-compatible cases. Also enum. Don't
grow this pattern...


Best regards,
Krzysztof