2022-03-18 05:43:36

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] wlwifi: mei: Fix build error without CFG80211

If CFG80211 is n and IWLMEI is y, building fails:

drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme':
net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen'

Make IWLMEI depends on CFG80211 to fix this.

Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index 85e704283755..8c003cd29ab7 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -137,7 +137,7 @@ endif

config IWLMEI
tristate "Intel Management Engine communication over WLAN"
- depends on INTEL_MEI
+ depends on INTEL_MEI && CFG80211
depends on PM
help
Enables the iwlmei kernel module.
--
2.17.1


2022-03-18 08:02:51

by Yue Haibing

[permalink] [raw]
Subject: Re: [PATCH -next] wlwifi: mei: Fix build error without CFG80211

On 2022/3/18 11:01, YueHaibing wrote:
> If CFG80211 is n and IWLMEI is y, building fails:
>
> drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme':
> net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen'
>
> Make IWLMEI depends on CFG80211 to fix this.
>

It seems has been fixed, Pls igbore this.

> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..8c003cd29ab7 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -137,7 +137,7 @@ endif
>
> config IWLMEI
> tristate "Intel Management Engine communication over WLAN"
> - depends on INTEL_MEI
> + depends on INTEL_MEI && CFG80211
> depends on PM
> help
> Enables the iwlmei kernel module.
>