2020-04-13 05:42:43

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

On Sun, 2020-04-12 at 23:20 +0200, Christophe JAILLET wrote:
> s/mvmeta/mvneta/

nice. how did you find this?

> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
[]
> @@ -5383,7 +5383,7 @@ static int __init mvneta_driver_init(void)
> {
> int ret;
>
> - ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, "net/mvmeta:online",
> + ret = cpuhp_setup_state_multi(CPUHP_AP_ONLINE_DYN, "net/mvneta:online",



2020-04-13 11:17:59

by Christophe JAILLET

[permalink] [raw]
Subject: Re: [PATCH] net: mvneta: Fix a typo

Le 12/04/2020 à 23:35, Joe Perches a écrit :
> On Sun, 2020-04-12 at 23:20 +0200, Christophe JAILLET wrote:
>> s/mvmeta/mvneta/
> nice. how did you find this?


Hi,

This is based on a bash script I've made a while ago (see [1])
I've slightly updated it, but the idea is still the same. I search
strings in a file with some variation on the file name (2 inverted
chars, 1 missing char or 1 modified char).

The output is horrible, and a lot of filtering should be done.
It is much like noise, with MANY false positives. But I manage to dig
some interesting stuff out of it.

If interested in the updated script, just ask, but except the concept
itself, I'm not sure than anything else worth anything and is should be
rewritten from scratch.

The update includes some tweaks in order to search into Kconfig files
instead.

CJ

[1]: https://marc.info/?l=kernel-janitors&m=156382201306781&w=4