2009-09-16 09:06:53

by Julia Lawall

Subject: [PATCH] arch/arm: adjust duplicate structure field initialization

From: Julia Lawall <[email protected]>

Currently the irq_type field of the csb726_lan_config structure is
initialized twice. The value in the first case,
SMSC911X_IRQ_POLARITY_ACTIVE_LOW, is normally stored in the irq_polarity
field, so I have renamed the field in the first initialization to that.

Signed-off-by: Julia Lawall <[email protected]>

---
arch/arm/mach-pxa/csb726.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-pxa/csb726.c b/arch/arm/mach-pxa/csb726.c
index 79141f8..965480e 100644
--- a/arch/arm/mach-pxa/csb726.c
+++ b/arch/arm/mach-pxa/csb726.c
@@ -238,7 +238,7 @@ static struct resource csb726_lan_resources[] = {
};

struct smsc911x_platform_config csb726_lan_config = {
- .irq_type = SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
+ .irq_polarity = SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
.irq_type = SMSC911X_IRQ_TYPE_PUSH_PULL,
.flags = SMSC911X_USE_32BIT,
.phy_interface = PHY_INTERFACE_MODE_MII,

2009-09-16 14:47:15

by Eric Miao

Subject: Re: [PATCH] arch/arm: adjust duplicate structure field initialization

On Wed, Sep 16, 2009 at 5:06 PM, Julia Lawall <[email protected]> wrote:
> From: Julia Lawall <[email protected]>
>
> Currently the irq_type field of the csb726_lan_config structure is
> initialized twice.  The value in the first case,
> SMSC911X_IRQ_POLARITY_ACTIVE_LOW, is normally stored in the irq_polarity
> field, so I have renamed the field in the first initialization to that.
>
> Signed-off-by: Julia Lawall <[email protected]>
>

Applied to 'fix'.