2009-09-30 12:07:04

by Pavel Machek

[permalink] [raw]
Subject: 2.6.32-rc1: spitz boots but suspend/resume is broken

Hi!

matrix keyboard driver needs to be enabled, otherwise it seems ok.

Unfortunately, it does not respond to power button in any visible way
:-(. Any ideas what might be wrong/how to debug it?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


2009-09-30 12:09:22

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
> Hi!
>
> matrix keyboard driver needs to be enabled, otherwise it seems ok.
>
> Unfortunately, it does not respond to power button in any visible way
> :-(. Any ideas what might be wrong/how to debug it?

Enable gpio-keyboard driver, verify (or port power button to it :))
and check that
enable_wakeup is enabled.

BTW: on tosa initially i had a problem w/ wakeup. The power button wasn't
able to wake the device up. However there was another gpio that was OR of
power button and AC-in gpios that had to be used for wakeup. Please check
if the same design applies to your device.

> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>



--
With best wishes
Dmitry

2009-09-30 12:10:43

by Eric Miao

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

Mmm.... if not due to kernel image size constraints, I'd really like to merge
all the zaurus configs into one.

On Wed, Sep 30, 2009 at 8:09 PM, Dmitry Eremin-Solenikov
<[email protected]> wrote:
> On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
>> Hi!
>>
>> matrix keyboard driver needs to be enabled, otherwise it seems ok.
>>
>> Unfortunately, it does not respond to power button in any visible way
>> :-(. Any ideas what might be wrong/how to debug it?
>
> Enable gpio-keyboard driver, verify (or port power button to it :))
> and check that
> enable_wakeup is enabled.
>
> BTW: on tosa initially i had a problem w/ wakeup. The power button wasn't
> able to wake the device up. However there was another gpio that was OR of
>  power button and AC-in gpios that had to be used for wakeup. Please check
> if the same design applies to your device.
>
>>                                                                Pavel
>> --
>> (english) http://www.livejournal.com/~pavelmachek
>> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>>
>
>
>
> --
> With best wishes
> Dmitry
>

2009-09-30 20:13:05

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

On Wed 2009-09-30 16:09:25, Dmitry Eremin-Solenikov wrote:
> On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
> > Hi!
> >
> > matrix keyboard driver needs to be enabled, otherwise it seems ok.
> >
> > Unfortunately, it does not respond to power button in any visible way
> > :-(. Any ideas what might be wrong/how to debug it?
>
> Enable gpio-keyboard driver, verify (or port power button to it :))
> and check that
> enable_wakeup is enabled.

Is there easy way to enable old driver, first?

I'd like to verify that nothing else broke... there were tons of
changes in rc1.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2009-10-02 07:07:31

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

On Wed 2009-09-30 16:09:25, Dmitry Eremin-Solenikov wrote:
> On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
> > Hi!
> >
> > matrix keyboard driver needs to be enabled, otherwise it seems ok.
> >
> > Unfortunately, it does not respond to power button in any visible way
> > :-(. Any ideas what might be wrong/how to debug it?
>
> Enable gpio-keyboard driver, verify (or port power button to it :))
> and check that
> enable_wakeup is enabled.

It seems neccessary tables for gpio-keyboard just are not there :-(.

In the meantime, this allows easy switch to known-good driver. (Can we
get it upstream until problem is fixed properly?)

Unfortunately, that still does not fix suspend/resume. (Does it work
for you?)

> BTW: on tosa initially i had a problem w/ wakeup. The power button wasn't
> able to wake the device up. However there was another gpio that was OR of
> power button and AC-in gpios that had to be used for wakeup. Please check
> if the same design applies to your device.

Well, it all worked in 2.6.31. How do I check it?

Pavel
---

Switch back to known-good keyboard driver. The new one does not
support power key, making suspend unusable.

This actually fixes regression from 2.6.31 (power key now works) but
not suspend/resume regression (will have to hunt more).

Signed-off-by: Pavel Machek <[email protected]>

diff -ur linux-rc/arch/arm.ofic/mach-pxa/spitz.c linux-rc/arch/arm/mach-pxa/spitz.c
--- linux-rc/arch/arm.ofic/mach-pxa/spitz.c 2009-09-28 12:09:26.000000000 +0200
+++ linux-rc/arch/arm/mach-pxa/spitz.c 2009-09-30 22:27:43.000000000 +0200
@@ -367,7 +367,8 @@
};

static struct platform_device spitzkbd_device = {
- .name = "matrix-keypad",
+ // .name = "matrix-keypad",
+ .name = "spitz-keyboard",
.id = -1,
.dev = {
.platform_data = &spitzkbd_pdata,


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2009-10-02 07:32:07

by Sascha Hauer

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

Hi,

On Fri, Oct 02, 2009 at 06:10:15AM +0200, Pavel Machek wrote:
> On Wed 2009-09-30 16:09:25, Dmitry Eremin-Solenikov wrote:
> > On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
> > > Hi!
> > >
> > > matrix keyboard driver needs to be enabled, otherwise it seems ok.
> > >
> > > Unfortunately, it does not respond to power button in any visible way
> > > :-(. Any ideas what might be wrong/how to debug it?
> >
> > Enable gpio-keyboard driver, verify (or port power button to it :))
> > and check that
> > enable_wakeup is enabled.
>
> It seems neccessary tables for gpio-keyboard just are not there :-(.
>
> In the meantime, this allows easy switch to known-good driver. (Can we
> get it upstream until problem is fixed properly?)
>
> Unfortunately, that still does not fix suspend/resume. (Does it work
> for you?)

Are you using the serial console on spitz? If yes, this might be
interesting for you:

http://bugzilla.kernel.org/show_bug.cgi?id=14297

I ended up with a console with 9600 baud after resume. My system resumed
correctly, but I did not see anything.

Sascha


--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2009-10-02 21:03:45

by Pavel Machek

[permalink] [raw]
Subject: Re: 2.6.32-rc1: spitz boots but suspend/resume is broken

On Fri 2009-10-02 09:32:05, Sascha Hauer wrote:
> Hi,
>
> On Fri, Oct 02, 2009 at 06:10:15AM +0200, Pavel Machek wrote:
> > On Wed 2009-09-30 16:09:25, Dmitry Eremin-Solenikov wrote:
> > > On Wed, Sep 30, 2009 at 4:06 PM, Pavel Machek <[email protected]> wrote:
> > > > Hi!
> > > >
> > > > matrix keyboard driver needs to be enabled, otherwise it seems ok.
> > > >
> > > > Unfortunately, it does not respond to power button in any visible way
> > > > :-(. Any ideas what might be wrong/how to debug it?
> > >
> > > Enable gpio-keyboard driver, verify (or port power button to it :))
> > > and check that
> > > enable_wakeup is enabled.
> >
> > It seems neccessary tables for gpio-keyboard just are not there :-(.
> >
> > In the meantime, this allows easy switch to known-good driver. (Can we
> > get it upstream until problem is fixed properly?)
> >
> > Unfortunately, that still does not fix suspend/resume. (Does it work
> > for you?)
>
> Are you using the serial console on spitz? If yes, this might be
> interesting for you:

I don't have serial cable :(.

> http://bugzilla.kernel.org/show_bug.cgi?id=14297
>
> I ended up with a console with 9600 baud after resume. My system resumed
> correctly, but I did not see anything.

...but someone with serial cable capturing 2.6.32-rc2 resume would
certainly be welcome :).
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html