2022-02-14 21:16:37

by Sergey Shtylyov

[permalink] [raw]
Subject: Re: [PATCH] ata: add/use ata_taskfile::{error|status} fields

On 2/14/22 11:43 PM, Sergey Shtylyov wrote:

> Add the explicit error and status register fields to 'struct ata_taskfile'
> using the anonymous *union*s ('struct ide_taskfile' had that for ages!) and
> update the libata taskfile code accordingly. There should be no object code
> changes resulting from that...
>
> Signed-off-by: Sergey Shtylyov <[email protected]>
>
> ---
> This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git'
> repo plus just posted 'drivers/ata/libata-scsi.c' patch.

Oh, and the 2 patch series for 'drivers/ata/libata-sff.c' posted not so long ago...
There are only some offsets, so should probably apply indeptendently as well... :-)

MBR, Sergey


2022-02-15 14:49:14

by Sergey Shtylyov

[permalink] [raw]
Subject: Re: [PATCH] ata: add/use ata_taskfile::{error|status} fields

On 2/15/22 12:13 AM, Sergey Shtylyov wrote:

>> Add the explicit error and status register fields to 'struct ata_taskfile'
>> using the anonymous *union*s ('struct ide_taskfile' had that for ages!) and
>> update the libata taskfile code accordingly. There should be no object code
>> changes resulting from that...
>>
>> Signed-off-by: Sergey Shtylyov <[email protected]>
>>
>> ---
>> This patch is against the 'for-next' branch of Damien Le Moal's 'libata.git'
>> repo plus just posted 'drivers/ata/libata-scsi.c' patch.
>
> Oh, and the 2 patch series for 'drivers/ata/libata-sff.c' posted not so long ago...
> There are only some offsets, so should probably apply indeptendently as well... :-)

The 0-day robot found a bug in the file I forgot to build check, so scratch this patch.
I've now fixed the bug and built tested all affected files, and gonna post v2 later today...

MBR, Sergey