2021-04-13 16:50:23

by Geert Uytterhoeven

Subject: [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE

The Apple Interrupt Controller is only present on Apple Silicon SoCs.
Hence add a dependency on ARCH_APPLE, to prevent asking the user about
this driver when configuring a kernel without Apple Silicon SoC support.

Drop the default, as ARCH_APPLE already selects APPLE_AIC.

Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index d3a14f304ec80caa..b165b3285d9b0555 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -580,7 +580,7 @@ config MST_IRQ
config APPLE_AIC
bool "Apple Interrupt Controller (AIC)"
depends on ARM64
- default ARCH_APPLE
+ depends on ARCH_APPLE || COMPILE_TEST
help
Support for the Apple Interrupt Controller found on Apple Silicon SoCs,
such as the M1.
--
2.25.1

2021-04-27 11:08:25

by Hector Martin

Subject: Re: [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE

On 13/04/2021 21.21, Geert Uytterhoeven wrote:
> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
> this driver when configuring a kernel without Apple Silicon SoC support.
>
> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
>
> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Makes sense. Thanks!

Acked-by: Hector Martin <[email protected]>

--
Hector Martin ([email protected])
Public Key: https://mrcn.st/pub

2021-04-27 12:38:16

by Marc Zyngier

Subject: Re: [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE

On 2021-04-27 12:07, Hector Martin wrote:
> On 13/04/2021 21.21, Geert Uytterhoeven wrote:
>> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
>> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
>> this driver when configuring a kernel without Apple Silicon SoC
>> support.
>>
>> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
>>
>> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple
>> Interrupt Controller")
>> Signed-off-by: Geert Uytterhoeven <[email protected]>
>> ---
>> drivers/irqchip/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Makes sense. Thanks!
>
> Acked-by: Hector Martin <[email protected]>

I'll pick this up post -rc1.

Thanks,

M.
--
Jazz is not dead. It just smells funny...