2023-07-20 02:56:15

by Ran Sun

[permalink] [raw]
Subject: [PATCH] [media] dvb-frontends: add missing spaces before ','

Add missing spaces to clear checkpatch errors.

ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Ran Sun <[email protected]>
---
drivers/media/dvb-frontends/dib3000mc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/dib3000mc.h
b/drivers/media/dvb-frontends/dib3000mc.h
index 5ed3d9147f8b..b837e107881e 100644
--- a/drivers/media/dvb-frontends/dib3000mc.h
+++ b/drivers/media/dvb-frontends/dib3000mc.h
@@ -73,7 +73,7 @@ struct i2c_adapter
*dib3000mc_get_tuner_i2c_master(struct dvb_frontend *demod,
}
#endif // CONFIG_DVB_DIB3000MC

-extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index,
int pid,int onoff);
+extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index,
int pid, int onoff);
extern int dib3000mc_pid_parse(struct dvb_frontend *fe, int onoff);

extern void dib3000mc_set_config(struct dvb_frontend *, struct
dib3000mc_config *);


2023-08-07 11:12:23

by Hans Verkuil

[permalink] [raw]
Subject: Re: [PATCH] [media] dvb-frontends: add missing spaces before ','

Hi Ran Sun,

On 20/07/2023 04:37, [email protected] wrote:
> Add missing spaces to clear checkpatch errors.
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <[email protected]>

The patch in patchwork is corrupt:

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

Probably line wrapping issues. Please check your mailer settings!

Regards,

Hans

> ---
>  drivers/media/dvb-frontends/dib3000mc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/dib3000mc.h b/drivers/media/dvb-frontends/dib3000mc.h
> index 5ed3d9147f8b..b837e107881e 100644
> --- a/drivers/media/dvb-frontends/dib3000mc.h
> +++ b/drivers/media/dvb-frontends/dib3000mc.h
> @@ -73,7 +73,7 @@ struct i2c_adapter *dib3000mc_get_tuner_i2c_master(struct dvb_frontend *demod,
>  }
>  #endif // CONFIG_DVB_DIB3000MC
>
> -extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index, int pid,int onoff);
> +extern int dib3000mc_pid_control(struct dvb_frontend *fe, int index, int pid, int onoff);
>  extern int dib3000mc_pid_parse(struct dvb_frontend *fe, int onoff);
>
>  extern void dib3000mc_set_config(struct dvb_frontend *, struct dib3000mc_config *);