2020-04-15 22:05:37

by Tang Bin

[permalink] [raw]
Subject: [PATCH] power: supply: axp288_charger: Omit superfluous error message

In the axp288_charger_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Signed-off-by: Tang Bin <[email protected]>
Signed-off-by: Shengju Zhang <[email protected]>
---
drivers/power/supply/axp288_charger.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
index 1bbba6bba..16fb4ae1c 100644
--- a/drivers/power/supply/axp288_charger.c
+++ b/drivers/power/supply/axp288_charger.c
@@ -825,10 +825,9 @@ static int axp288_charger_probe(struct platform_device *pdev)
/* Register charger interrupts */
for (i = 0; i < CHRG_INTR_END; i++) {
pirq = platform_get_irq(info->pdev, i);
- if (pirq < 0) {
- dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq);
+ if (pirq < 0)
return pirq;
- }
+
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_warn(&info->pdev->dev,
--
2.20.1.windows.1




2020-04-15 22:29:20

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] power: supply: axp288_charger: Omit superfluous error message

Hi,

On 4/15/20 6:27 AM, Tang Bin wrote:
> In the axp288_charger_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant
> message here.
>
> Signed-off-by: Tang Bin <[email protected]>
> Signed-off-by: Shengju Zhang <[email protected]>

Thank you for this nice cleanup patch:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/power/supply/axp288_charger.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c
> index 1bbba6bba..16fb4ae1c 100644
> --- a/drivers/power/supply/axp288_charger.c
> +++ b/drivers/power/supply/axp288_charger.c
> @@ -825,10 +825,9 @@ static int axp288_charger_probe(struct platform_device *pdev)
> /* Register charger interrupts */
> for (i = 0; i < CHRG_INTR_END; i++) {
> pirq = platform_get_irq(info->pdev, i);
> - if (pirq < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq);
> + if (pirq < 0)
> return pirq;
> - }
> +
> info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
> if (info->irq[i] < 0) {
> dev_warn(&info->pdev->dev,
>

2020-04-16 01:35:19

by Tang Bin

[permalink] [raw]
Subject: Re: [PATCH] power: supply: axp288_charger: Omit superfluous errormessage

Hi Hans:

On 2020/4/15 16:07, Hans de Goede wrote:
> Hi,
>
> On 4/15/20 6:27 AM, Tang Bin wrote:
>> In the axp288_charger_probe(), when get irq failed, the function
>> platform_get_irq() logs an error message, so remove redundant
>> message here.
>>
>> Signed-off-by: Tang Bin <[email protected]>
>> Signed-off-by: Shengju Zhang <[email protected]>
>
> Thank you for this nice cleanup patch:
>
> Reviewed-by: Hans de Goede <[email protected]>
>
Thanks,

Tang Bin

>
>
>
>


2020-04-28 23:52:28

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] power: supply: axp288_charger: Omit superfluous error message

Hi,

On Wed, Apr 15, 2020 at 10:07:03AM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/15/20 6:27 AM, Tang Bin wrote:
> > In the axp288_charger_probe(), when get irq failed, the function
> > platform_get_irq() logs an error message, so remove redundant
> > message here.
> >
> > Signed-off-by: Tang Bin <[email protected]>
> > Signed-off-by: Shengju Zhang <[email protected]>
>
> Thank you for this nice cleanup patch:
>
> Reviewed-by: Hans de Goede <[email protected]>

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (550.00 B)
 signature.asc (849.00 B)
 Download all attachments