2022-09-19 06:33:34

by Lukas Bulwahn

Subject: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
i.e., RAID_ATTRS needs to be m when SCSI=m.

This helper config symbol SCSI_MOD still shows up even in kernel
configurations that do not select the block subsystem and where SCSI is
not even a configuration option mentioned and selectable.

Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is
slightly relevant in the kernel configuration.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/scsi/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 955cb69a5418..03e71e3d5e5b 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -2,9 +2,10 @@
menu "SCSI device support"

config SCSI_MOD
- tristate
- default y if SCSI=n || SCSI=y
- default m if SCSI=m
+ tristate
+ default y if SCSI=n || SCSI=y
+ default m if SCSI=m
+ depends on BLOCK

config RAID_ATTRS
tristate "RAID Transport Class"
--
2.17.1

2022-09-22 22:08:17

by Bart Van Assche

Subject: Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

On 9/18/22 23:01, Lukas Bulwahn wrote:
> SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
> i.e., RAID_ATTRS needs to be m when SCSI=m.
>
> This helper config symbol SCSI_MOD still shows up even in kernel
> configurations that do not select the block subsystem and where SCSI is
> not even a configuration option mentioned and selectable.
>
> Make this SCSI_MOD depend on BLOCK, so that it only shows up when it is
> slightly relevant in the kernel configuration.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/scsi/Kconfig | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 955cb69a5418..03e71e3d5e5b 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -2,9 +2,10 @@
> menu "SCSI device support"
>
> config SCSI_MOD
> - tristate
> - default y if SCSI=n || SCSI=y
> - default m if SCSI=m
> + tristate
> + default y if SCSI=n || SCSI=y
> + default m if SCSI=m
> + depends on BLOCK

Reviewed-by: Bart Van Assche <[email protected]>

2022-09-25 17:04:36

by Martin K. Petersen

Subject: Re: [PATCH] scsi: make SCSI_MOD depend on BLOCK for cleaner .config files

Lukas,

> SCSI_MOD is a helper config symbol for configuring RAID_ATTRS properly,
> i.e., RAID_ATTRS needs to be m when SCSI=m.

Applied to 6.1/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering