2022-10-31 17:25:27

by Neil Armstrong

Subject: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
to its two PMICs in order, this represents the poweroff scheme needed to complet
a clean poeroff of the system.

Signed-off-by: Neil Armstrong <[email protected]>
---
.../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
new file mode 100644
index 000000000000..65e42258717c
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Hardkernel Odroid Go Ultra poweroff
+
+maintainers:
+ - Neil Armstrong <[email protected]>
+
+description:
+ The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
+ to its two PMICs in order, this represents the poweroff scheme needed to complete
+ a clean poeroff of the system.
+
+properties:
+ compatible:
+ const: hardkernel,odroid-go-ultra-poweroff
+
+ hardkernel,rk817-pmic:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the RK817 PMIC node
+
+ hardkernel,rk818-pmic:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: Phandle to the RK818 PMIC node
+
+required:
+ - compatible
+ - hardkernel,rk817-pmic
+ - hardkernel,rk818-pmic
+
+additionalProperties: false
+
+examples:
+ - |
+ poweroff {
+ compatible = "hardkernel,odroid-go-ultra-poweroff";
+ hardkernel,rk817-pmic = <&rk817>;
+ hardkernel,rk818-pmic = <&rk818>;
+ };

--
b4 0.10.1

2022-10-31 21:49:09

by Martin Blumenstingl

Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

Hi Neil,

On Mon, Oct 31, 2022 at 5:47 PM Neil Armstrong
<[email protected]> wrote:
>
> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> to its two PMICs in order, this represents the poweroff scheme needed to complet
s/complet/complete/
> a clean poeroff of the system.
s/poeroff/poweroff/

Please wait with re-sending this patch in case the dt-bindings and
reset experts have more to say than finding typos.


Best regards,
Martin

2022-11-02 09:06:40

by Neil Armstrong

Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

On 31/10/2022 22:16, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Oct 31, 2022 at 5:47 PM Neil Armstrong
> <[email protected]> wrote:
>>
>> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
>> to its two PMICs in order, this represents the poweroff scheme needed to complet
> s/complet/complete/
>> a clean poeroff of the system.
> s/poeroff/poweroff/
>
> Please wait with re-sending this patch in case the dt-bindings and
> reset experts have more to say than finding typos.

Thx for spotting those typos !

>
>
> Best regards,
> Martin

Neil

2022-11-02 16:37:00

by Rob Herring (Arm)

Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote:
> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> to its two PMICs in order, this represents the poweroff scheme needed to complet
> a clean poeroff of the system.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> new file mode 100644
> index 000000000000..65e42258717c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Hardkernel Odroid Go Ultra poweroff
> +
> +maintainers:
> + - Neil Armstrong <[email protected]>
> +
> +description:
> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
> + to its two PMICs in order, this represents the poweroff scheme needed to complete
> + a clean poeroff of the system.

You don't really need a node for this. Test against the top level
compatible and then find the PMIC nodes by their compatible strings.

> +
> +properties:
> + compatible:
> + const: hardkernel,odroid-go-ultra-poweroff
> +
> + hardkernel,rk817-pmic:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the RK817 PMIC node
> +
> + hardkernel,rk818-pmic:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Phandle to the RK818 PMIC node
> +
> +required:
> + - compatible
> + - hardkernel,rk817-pmic
> + - hardkernel,rk818-pmic
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + poweroff {
> + compatible = "hardkernel,odroid-go-ultra-poweroff";
> + hardkernel,rk817-pmic = <&rk817>;
> + hardkernel,rk818-pmic = <&rk818>;
> + };
>
> --
> b4 0.10.1
>

2022-11-02 17:31:35

by Neil Armstrong

Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off

Hi,

On 02/11/2022 17:23, Rob Herring wrote:
> On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote:
>> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
>> to its two PMICs in order, this represents the poweroff scheme needed to complet
>> a clean poeroff of the system.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
>> ---
>> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
>> new file mode 100644
>> index 000000000000..65e42258717c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml
>> @@ -0,0 +1,42 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Hardkernel Odroid Go Ultra poweroff
>> +
>> +maintainers:
>> + - Neil Armstrong <[email protected]>
>> +
>> +description:
>> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff
>> + to its two PMICs in order, this represents the poweroff scheme needed to complete
>> + a clean poeroff of the system.
>
> You don't really need a node for this. Test against the top level
> compatible and then find the PMIC nodes by their compatible strings.

Hmm ok, indeed would be simpler.

Neil

>
>> +
>> +properties:
>> + compatible:
>> + const: hardkernel,odroid-go-ultra-poweroff
>> +
>> + hardkernel,rk817-pmic:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: Phandle to the RK817 PMIC node
>> +
>> + hardkernel,rk818-pmic:
>> + $ref: /schemas/types.yaml#/definitions/phandle
>> + description: Phandle to the RK818 PMIC node
>> +
>> +required:
>> + - compatible
>> + - hardkernel,rk817-pmic
>> + - hardkernel,rk818-pmic
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + poweroff {
>> + compatible = "hardkernel,odroid-go-ultra-poweroff";
>> + hardkernel,rk817-pmic = <&rk817>;
>> + hardkernel,rk818-pmic = <&rk818>;
>> + };
>>
>> --
>> b4 0.10.1
>>