2017-11-16 06:17:27

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 10/12] isdn: hisax: Fix pnp_irq's error checking for setup_niccy

The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/isdn/hisax/niccy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/niccy.c b/drivers/isdn/hisax/niccy.c
index e4c33cf..dfbcd2e 100644
--- a/drivers/isdn/hisax/niccy.c
+++ b/drivers/isdn/hisax/niccy.c
@@ -261,7 +261,7 @@ int setup_niccy(struct IsdnCard *card)
card->para[1] = pnp_port_start(pnp_d, 0);
card->para[2] = pnp_port_start(pnp_d, 1);
card->para[0] = pnp_irq(pnp_d, 0);
- if (!card->para[0] || !card->para[1] ||
+ if (card->para[0] == -1 || !card->para[1] ||
!card->para[2]) {
printk(KERN_ERR "NiccyPnP:some resources are "
"missing %ld/%lx/%lx\n",
--
1.9.1


From 1584182759847190503@xxx Thu Nov 16 01:06:50 +0000 2017
X-GM-THRID: 1584134109068186639
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread