2023-07-13 12:02:50

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

On 13/07/2023 13:55, Sridharan S N wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDP) 417 based on IPQ9574 family of SoC.
>
> This patch depends on below patchset:
> https://lore.kernel.org/lkml/[email protected]/

This does not make sense in commit log. Why would you store it in commit
in the first place? Please put dependencies with changelog, so after ---
separator.

Best regards,
Krzysztof

2023-07-13 12:15:49

by Sridharan S N

Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

On 7/13/2023 5:28 PM, Krzysztof Kozlowski wrote:
> On 13/07/2023 13:55, Sridharan S N wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 417 based on IPQ9574 family of SoC.
>>
>> This patch depends on below patchset:
>> https://lore.kernel.org/lkml/[email protected]/
> This does not make sense in commit log. Why would you store it in commit
> in the first place? Please put dependencies with changelog, so after ---
> separator.
>
> Best regards,
> Krzysztof

Sorry,I overlooked it. Will move the dependencies to change log and post v2


Thanks,

Sridharan

>