Hi Martin,
On Mon, 2020-11-09 at 10:13 +0100, Martin Kepplinger wrote:
> As described in NXPs' linux tree, the imx8m SoC includes the same
> CSI bridge hardware that is part of imx7d. We should be able to
> use the "fsl,imx7-csi" driver for imx8m directly.
>
> Since ipuv3 is not relevant for imx8m, drop the build dependency
> for it.
>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
> drivers/staging/media/imx/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index f555aac8a9d5..98272fd92fe4 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -2,7 +2,7 @@
> config VIDEO_IMX_MEDIA
> tristate "i.MX5/6 V4L2 media core driver"
VIDEO_IMX_MEDIA builds imx6-media, which does depend on IMX_IPUV3_CORE.
You only want imx-media-common. I think we have to split the
configuration option in two.
> depends on ARCH_MXC || COMPILE_TEST
> - depends on VIDEO_V4L2 && IMX_IPUV3_CORE
> + depends on VIDEO_V4L2
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> depends on HAS_DMA
regards
Philipp
As described in NXPs' linux tree, the imx8m SoC includes the same
CSI bridge hardware that is part of imx7d. We should be able to
use the "fsl,imx7-csi" driver for imx8m directly.
Since ipuv3 is not relevant for imx8m we create VIDEO_IMX7_MEDIA and
split up the configuration option in 2 menus (on 1 entry each
for now but that can be changed later).
Signed-off-by: Martin Kepplinger <[email protected]>
---
thanks, you're right. did you have something like this in mind?
martin
drivers/staging/media/imx/Kconfig | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
index f555aac8a9d5..a888d9b918b5 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers/staging/media/imx/Kconfig
@@ -13,6 +13,20 @@ config VIDEO_IMX_MEDIA
Say yes here to enable support for video4linux media controller
driver for the i.MX5/6 SOC.
+config VIDEO_IMX7_MEDIA
+ tristate "i.MX7/8 V4L2 media core driver"
+ depends on ARCH_MXC || COMPILE_TEST
+ depends on VIDEO_V4L2
+ select MEDIA_CONTROLLER
+ select VIDEO_V4L2_SUBDEV_API
+ depends on HAS_DMA
+ select VIDEOBUF2_DMA_CONTIG
+ select V4L2_FWNODE
+ select V4L2_MEM2MEM_DEV
+ help
+ Say yes here to enable support for video4linux media controller
+ driver for the i.MX7/8M SOC.
+
if VIDEO_IMX_MEDIA
menu "i.MX5/6/7 Media Sub devices"
@@ -23,12 +37,19 @@ config VIDEO_IMX_CSI
help
A video4linux camera sensor interface driver for i.MX5/6.
+endmenu
+endif
+
+if VIDEO_IMX7_MEDIA
+menu "i.MX7/8 Media Sub devices"
+
config VIDEO_IMX7_CSI
- tristate "i.MX6UL/L / i.MX7 Camera Sensor Interface driver"
- depends on VIDEO_IMX_MEDIA && VIDEO_DEV && I2C
+ tristate "i.MX7 / i.MX8M Camera Sensor Interface driver"
+ depends on VIDEO_IMX7_MEDIA && VIDEO_DEV && I2C
default y
help
Enable support for video4linux camera sensor interface driver for
- i.MX6UL/L or i.MX7.
+ i.MX6UL/L, i.MX7 or i.MX8M.
+
endmenu
endif
--
2.20.1
On Mon, 2020-11-09 at 10:46 +0100, Martin Kepplinger wrote:
> As described in NXPs' linux tree, the imx8m SoC includes the same
> CSI bridge hardware that is part of imx7d. We should be able to
> use the "fsl,imx7-csi" driver for imx8m directly.
>
> Since ipuv3 is not relevant for imx8m we create VIDEO_IMX7_MEDIA and
> split up the configuration option in 2 menus (on 1 entry each
> for now but that can be changed later).
>
> Signed-off-by: Martin Kepplinger <[email protected]>
> ---
>
> thanks, you're right. did you have something like this in mind?
Not quite, we need a separate option for the imx-media-common module, so
the Makefile has to be changed as well. That option should be selected
by VIDEO_IMX_MEDIA.
I'm not sure if introducing VIDEO_IMX7_MEDIA is necessary, the new
option could also be hidden if selected VIDEO_IMX7_CSI directly.
regards
Philipp