2022-01-27 09:06:59

by CGEL

Subject: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

From: "Minghao Chi (CGEL ZTE)" <[email protected]>

'destroy_workqueue()' already drains the queue before destroying it,
so there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
Signed-off-by: CGEL ZTE <[email protected]>
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
index 76d3f0399964..60305c63c6f6 100644
--- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
@@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
mutex_unlock(&instance->vchiq_mutex);

vchiq_shutdown(instance->vchiq_instance);
- flush_workqueue(instance->bulk_wq);
destroy_workqueue(instance->bulk_wq);

vfree(instance->bulk_scratch);
--
2.25.1

2022-01-27 23:09:50

by Stefan Wahren

Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

Hi,

Am 27.01.22 um 02:44 schrieb [email protected]:
> From: "Minghao Chi (CGEL ZTE)" <[email protected]>
>
> 'destroy_workqueue()' already drains the queue before destroying it,
> so there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
are you sure that drain_workqueue() is the same as flush_workqueue()?
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi (CGEL ZTE) <[email protected]>
> Signed-off-by: CGEL ZTE <[email protected]>
> ---
> drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index 76d3f0399964..60305c63c6f6 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -1844,7 +1844,6 @@ int vchiq_mmal_finalise(struct vchiq_mmal_instance *instance)
> mutex_unlock(&instance->vchiq_mutex);
>
> vchiq_shutdown(instance->vchiq_instance);
> - flush_workqueue(instance->bulk_wq);
> destroy_workqueue(instance->bulk_wq);
>
> vfree(instance->bulk_scratch);

2022-01-30 03:42:02

by Dan Carpenter

Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
>
> Am 27.01.22 um 02:44 schrieb [email protected]:
> > From: "Minghao Chi (CGEL ZTE)" <[email protected]>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?

drain_workqueue() calls flush_workqueue() repeatedly.

regards,
dan carpenter

2022-01-31 10:00:51

by Stefan Wahren

Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls

Am 28.01.22 um 08:03 schrieb Dan Carpenter:
> On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
>> Hi,
>>
>> Am 27.01.22 um 02:44 schrieb [email protected]:
>>> From: "Minghao Chi (CGEL ZTE)" <[email protected]>
>>>
>>> 'destroy_workqueue()' already drains the queue before destroying it,
>>> so there is no need to flush it explicitly.
>>>
>>> Remove the redundant 'flush_workqueue()' calls.
>> are you sure that drain_workqueue() is the same as flush_workqueue()?
> drain_workqueue() calls flush_workqueue() repeatedly.

sorry, i overlooked this

I'm fine with the patch

>
> regards,
> dan carpenter
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel