Subject: [PATCH 1/2] rv/dot2c: Make automaton definition static

Monitor's automata definition is only used locally, so make dot2c generate
a static definition.

Link: https://lore.kernel.org/all/[email protected]
Link: https://lore.kernel.org/all/[email protected]

Cc: Steven Rostedt <[email protected]>
Fixes: e3c9fc78f096 ("tools/rv: Add dot2c")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Daniel Bristot de Oliveira <[email protected]>
---
tools/verification/dot2/dot2c.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py
index fa73353f7e56..be8a364a469b 100644
--- a/tools/verification/dot2/dot2c.py
+++ b/tools/verification/dot2/dot2c.py
@@ -111,7 +111,7 @@ class Dot2c(Automata):

def format_aut_init_header(self):
buff = []
- buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
+ buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
return buff

def __get_string_vector_per_line_content(self, buff):
--
2.35.1


2022-10-18 22:35:54

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

On Tue, 18 Oct 2022 18:25:53 -0400
Steven Rostedt <[email protected]> wrote:

> On Tue, 23 Aug 2022 17:20:28 +0200
> Daniel Bristot de Oliveira <[email protected]> wrote:
>
> > Monitor's automata definition is only used locally, so make dot2c generate
> > a static definition.
> >
> > Link: https://lore.kernel.org/all/[email protected]
> > Link: https://lore.kernel.org/all/[email protected]
> >
>
> Somehow this fell through the cracks.
>
> Daniel, is there any reason I shouldn't pull this in now?

I think when I applied:

https://patchwork.kernel.org/project/linux-trace-devel/patch/a50e27c3738d6ef809f4201857229fed64799234.1661266564.git.bristot@kernel.org/

I mistook that to be a new version of this patch.

-- Steve

2022-10-18 22:37:50

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

On Tue, 23 Aug 2022 17:20:28 +0200
Daniel Bristot de Oliveira <[email protected]> wrote:

> Monitor's automata definition is only used locally, so make dot2c generate
> a static definition.
>
> Link: https://lore.kernel.org/all/[email protected]
> Link: https://lore.kernel.org/all/[email protected]
>

Somehow this fell through the cracks.

Daniel, is there any reason I shouldn't pull this in now?

-- Steve

> Cc: Steven Rostedt <[email protected]>
> Fixes: e3c9fc78f096 ("tools/rv: Add dot2c")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Daniel Bristot de Oliveira <[email protected]>
> ---
> tools/verification/dot2/dot2c.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/verification/dot2/dot2c.py b/tools/verification/dot2/dot2c.py
> index fa73353f7e56..be8a364a469b 100644
> --- a/tools/verification/dot2/dot2c.py
> +++ b/tools/verification/dot2/dot2c.py
> @@ -111,7 +111,7 @@ class Dot2c(Automata):
>
> def format_aut_init_header(self):
> buff = []
> - buff.append("struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
> + buff.append("static struct %s %s = {" % (self.struct_automaton_def, self.var_automaton_def))
> return buff
>
> def __get_string_vector_per_line_content(self, buff):

Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

On 10/19/22 00:25, Steven Rostedt wrote:
> On Tue, 23 Aug 2022 17:20:28 +0200
> Daniel Bristot de Oliveira <[email protected]> wrote:
>
>> Monitor's automata definition is only used locally, so make dot2c generate
>> a static definition.
>>
>> Link: https://lore.kernel.org/all/[email protected]
>> Link: https://lore.kernel.org/all/[email protected]
>>
> Somehow this fell through the cracks.
>
> Daniel, is there any reason I shouldn't pull this in now?

Oops... yes, it can be pulled.

-- Daniel

2022-10-20 21:05:05

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH 1/2] rv/dot2c: Make automaton definition static

On Wed, 19 Oct 2022 15:15:54 +0200
Daniel Bristot de Oliveira <[email protected]> wrote:

> On 10/19/22 00:25, Steven Rostedt wrote:
> > On Tue, 23 Aug 2022 17:20:28 +0200
> > Daniel Bristot de Oliveira <[email protected]> wrote:
> >
> >> Monitor's automata definition is only used locally, so make dot2c generate
> >> a static definition.
> >>
> >> Link: https://lore.kernel.org/all/[email protected]
> >> Link: https://lore.kernel.org/all/[email protected]
> >>
> > Somehow this fell through the cracks.
> >
> > Daniel, is there any reason I shouldn't pull this in now?
>
> Oops... yes, it can be pulled.
>

OK, I'm going to push this up as tools/urgent and send a pull request to
Linus.

-- Steve